Adrian, Xiang,

Could you please verify this and mark 'verification-done' ?

At this point, this bug is blocking the release of cloud-init 0.7.8-49
-g9e904bb-0ubuntu1~16.04.2 from xenial-proposed.  That change contains
fixes for other bugs that we need to get into -updates.

I've made requests off-bug to both Xiang Hui and to Adrian Vladu, but
have not gotten a response.

Adrian has ACKed the upstream merge proposal at [1] with this fix.

While the code change does change behavior, the chance for regression is
very low.  See the code that was changed in context at [2].  Basically
we extended the list of "physical types" to add 'hw_veb', 'hyperv',
'vhostuser'.  Previously, if that condition did not match, then we would
raise a ValueError exception that is not handled, leaving the system
basically un-usable.  Now, the strings are considered valid as
"physical" and cloud-init will configure the devices as needed.

So:
  Before: cloud-init raise exception and no user-data or metadata is used... 
user cannot log into system.
  After: cloud-init configures networking and user-data and metadata is used.

Worst case for regression is really "still doesn't work".

--
[1] https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/311548
[2] 
https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py#n599

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1642679

Title:
  The OpenStack network_config.json implementation fails on Hyper-V
  compute nodes

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1642679/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to