** Description changed:
+ [SRU Justification]
+ The errinjct tool cannot run EEH tests on certain systems. This is a
relatively low priority hardware enablement SRU (low priority because the tool
in question is a test tool only).
+
+ [Test case]
+ 1. On a Shiner-T or Grand Canyon system, run the command: sudo errinjct eeh
-v -f 6 -s net/enp1s0d0 -a 0x82100000 -m 0x0000FFFFFF800000
+ 2. Verify that this returns an error.
+ 3. Enable xenial-proposed, and upgrade powerpc-utils.
+ 4. Rerun the errinjct command. Verify that it now succeeds.
+
+ [Regression potential]
+ Minimal; this is a test tool only so any regressions will be low impact, and
the upstream changes that have been cherry-picked are reasonably limited in
scope.
+
== Comment: #0 - Manvanthara B. Puttashankar - 2016-06-29 01:40:42 ==
---Problem Description---
errinjct tool error while running EEH tests (powerpc-utils)
-
+
---uname output---
Linux ltciofvtr-s822l2-lp3 4.4.0-24-generic #43-Ubuntu SMP Wed Jun 8 19:25:36
UTC 2016 ppc64le ppc64le ppc64le GNU/Linux
-
- Machine Type = s822l
-
+
+ Machine Type = s822l
+
---Steps to Reproduce---
- errinjct tool needs to pick two patch to address the below error
-
+ errinjct tool needs to pick two patch to address the below error
errinjct eeh -v -f 6 -s net/eth1 -a 0xde000000 -m 0x0000FFFFFF800000
Injecting an ioa-bus-error with the following data:
BUS ADDR: de000000
ADDR MASK: ffffff800000
CONFIG ADDR: 900000
PHB UNIT_ID: 800000020000135
FUNCTION: 6
Store to PCI Memory Address Space - inject an Adress Parity Error
errinjct: Could not open RTAS error injection facility
errinjct: librtas returned an unknown error code (-50331649) for function
ioa-bus-error
Parent bug: Bug 121866 : EEH via errinjct tool fails with librtas error
in Ubuntu 16.04 (Shiner-T & Grand Canyon)
errinjct issues will be solved with multiple patches 1 librtas + 2
errijnct.
Based on suggestion from developer in Bug 121866 reporting this
specific issue to powerpc-utils package , two patch needs to be picked
by canonical.
Note: have verified the powerpc-utils for 16.04.01 , the patch hasn't
gone into yet.
- upstream patch fix link:
https://github.com/nfont/powerpc-utils/tree/next/src/errinjct
-
- Userspace tool common name: errinjct
-
- The userspace tool has the following bit modes: ppc64le
+ upstream patch fix link: https://github.com/nfont/powerpc-
+ utils/tree/next/src/errinjct
+
+ Userspace tool common name: errinjct
+
+ The userspace tool has the following bit modes: ppc64le
Userspace rpm: powerpc-utils
-
== Comment: #1 - Manvanthara B. Puttashankar <mputt...@in.ibm.com> -
2016-06-29 01:48:02 ==
commits to be picked up
-
commit 386a07c4dc6c09d35116dc6064f7a83d76f4415b
Author: Nathan Fontenot <nf...@linux.vnet.ibm.com>
Date: Tue May 24 16:32:39 2016 -0400
- errinjct: Correct read_file() error checking
-
- When reading files from syfs the file length returned from a stat()
- call does not always match the actual length of the file. The read_file()
- routine should be checking for an error return from the read() call
- instead of checking that the amount read matches the file length returned
- from a stat() call.
-
- Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
+ errinjct: Correct read_file() error checking
+
+ When reading files from syfs the file length returned from a stat()
+ call does not always match the actual length of the file. The read_file()
+ routine should be checking for an error return from the read() call
+ instead of checking that the amount read matches the file length returned
+ from a stat() call.
+
+ Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
commit 42b83884bfb51c0c8b23bf2949157430f8468caa
Author: Nathan Fontenot <nf...@linux.vnet.ibm.com>
Date: Tue May 24 16:31:37 2016 -0400
- errinjct: Recognize -5 return from rtas
-
- Update the errinjct command to recognize the rturn code of -5 from
- rtas indicating that PCI error injection is not enabled.
-
- Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
+ errinjct: Recognize -5 return from rtas
+ Update the errinjct command to recognize the rturn code of -5 from
+ rtas indicating that PCI error injection is not enabled.
+
+ Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
commit ab848a8d5cc4c4b9f5faef1b31be3982fb7d4bf2
Author: Nathan Fontenot <nf...@linux.vnet.ibm.com>
Date: Tue May 24 16:30:33 2016 -0400
- errinjct: Correct config_addr parsing
-
- A recent patch (commit id: ccc9c72cec2a4) to move the errinjct function to
- using a common read_file() routine did not correctly update the
- get_config_addr_from_reg() function. This patch corrects this to return
the
- proper config address.
-
- Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
+ errinjct: Correct config_addr parsing
+
+ A recent patch (commit id: ccc9c72cec2a4) to move the errinjct function to
+ using a common read_file() routine did not correctly update the
+ get_config_addr_from_reg() function. This patch corrects this to return
the
+ proper config address.
+
+ Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>
** Changed in: powerpc-utils (Ubuntu Xenial)
Importance: Undecided => Medium
** Changed in: powerpc-utils (Ubuntu Xenial)
Status: New => In Progress
** Changed in: powerpc-utils (Ubuntu Xenial)
Assignee: (unassigned) => Steve Langasek (vorlon)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1597365
Title:
errinjct tool error while running EEH tests (powerpc-utils)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/powerpc-utils/+bug/1597365/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
