This patch is broken:

1. $OPTIONS is used (unquoted) in 4 different places but this patch only 
updates one of them
2. Quoting $OPTIONS prevents use of multiple options

Unfortunately I don't see a reasonable way to fix this while using only
POSIX shell features.

- If bzdiff is changed to use bash then the options can be accumulated into an 
array variable.  This would be fine in Debian and Ubuntu, but not upstream.
- POSIX allows positional arguments to be used in an array-like way, but we 
already use them for the filenames.
- This could be done by escaping, quoting and concatenating the options and 
then using eval to expand to multiple arguments.  But this is not what I would 
consider reasonable!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/735675

Title:
  bzdiff does not pass -I option to diff

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bzip2/+bug/735675/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to