** Description changed:
[Impact]
- * There is a typo in ERRMSG of function show_mem_usage affecting Xenial
- and Zesty AND Debian.
+ * There is a typo in ERRMSG of function show_mem_usage affecting
+ Xenial/Zesty, Debian and makedumpfile upstream.
This should be :
"show_mem_usage: No memory is reserved for crashkernel!"
instead of :
"show_mem_usage: No memory is reserved for crashkenrel!"
- The typo is located here in src code for Xenial and Zesty (devel
- release) AND Debian:
+ The typo is located here in src code :
+
# filename : makedumpfile.c
- 10447 int show_mem_usage(void)
- 10448 {
- 10449 uint64_t vmcoreinfo_addr, vmcoreinfo_len;
- 10450 struct cycle cycle = {0};
- 10451
- 10452 if (!is_crashkernel_mem_reserved()) {
- 10453 ERRMSG("No memory is reserved for crashkenrel!\n");
- 10454 return FALSE;
- 10455 }
+ -
+ int show_mem_usage(void)
+ {
+ uint64_t vmcoreinfo_addr, vmcoreinfo_len;
+ struct cycle cycle = {0};
+
+ if (!is_crashkernel_mem_reserved()) {
+ ERRMSG("No memory is reserved for crashkenrel!\n");
+ return FALSE;
+ }
+ -
[Test Case]
* Take a system with no crashkernel memory reservation set
* run command : makedumpfile --mem-usage /proc/kcore
* Error message :
show_mem_usage: No memory is reserved for crashkenrel!
[Regression Potential]
* No regression, it is a trivial change with no behavioural change.
[Other Info]
* Upstream:
Patch has been submitted upstream (ML :[email protected])
* Debian bug :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051
** Description changed:
[Impact]
* There is a typo in ERRMSG of function show_mem_usage affecting
Xenial/Zesty, Debian and makedumpfile upstream.
This should be :
"show_mem_usage: No memory is reserved for crashkernel!"
instead of :
"show_mem_usage: No memory is reserved for crashkenrel!"
The typo is located here in src code :
-
# filename : makedumpfile.c
-
- int show_mem_usage(void)
- {
- uint64_t vmcoreinfo_addr, vmcoreinfo_len;
- struct cycle cycle = {0};
+ int show_mem_usage(void)
+ {
+ uint64_t vmcoreinfo_addr, vmcoreinfo_len;
+ struct cycle cycle = {0};
- if (!is_crashkernel_mem_reserved()) {
- ERRMSG("No memory is reserved for crashkenrel!\n");
- return FALSE;
- }
+ if (!is_crashkernel_mem_reserved()) {
+ ==> ERRMSG("No memory is reserved for crashkenrel!\n");
+ return FALSE;
+ }
-
[Test Case]
* Take a system with no crashkernel memory reservation set
* run command : makedumpfile --mem-usage /proc/kcore
* Error message :
show_mem_usage: No memory is reserved for crashkenrel!
[Regression Potential]
* No regression, it is a trivial change with no behavioural change.
[Other Info]
* Upstream:
Patch has been submitted upstream (ML :[email protected])
* Debian bug :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051
** Changed in: makedumpfile (Ubuntu Xenial)
Importance: Low => Medium
** Changed in: makedumpfile (Ubuntu Zesty)
Importance: Low => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1670696
Title:
Typo in error msg when no crashkernel memory reservation is set
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1670696/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
