Public bug reported:

Hi, looks like the systemd service file contains a comma where it should
not. Even when not enabled, journalctl shows:

$ journalctl | grep onionbalance
Mar 15 00:10:51 lab16 systemd[1]: [/lib/systemd/system/onionbalance.service:8] 
Failed to add dependency on network.target,, ignoring: Invalid argument

The same typo exists in all Ubuntu onionbalance packages I checked
(xenial, yakkety and zesty) and is easily fixed by removing the
erroneous comma on line 8.

Regards.

= = =

$ cat /lib/systemd/system/onionbalance.service
# OnionBalance systemd target

[Unit]
Description=OnionBalance - Tor Onion Service load balancer
Documentation=man:onionbalance
Documentation=file:///usr/share/doc/onionbalance/html/index.html
Documentation=https://github.com/DonnchaC/onionbalance
After=network.target, tor.target    
<------------------------------------------------------ culprit
Wants=network-online.target
ConditionPathExists=/etc/onionbalance/config.yaml

[Service]
Type=simple
PIDFile=/run/onionbalance.pid
Environment="ONIONBALANCE_LOG_LOCATION=/var/log/onionbalance/log"
ExecStart=/usr/sbin/onionbalance -c /etc/onionbalance/config.yaml
ExecReload=/usr/sbin/onionbalance reload
ExecStop=-/sbin/start-stop-daemon --quiet --stop --retry=TERM/5/KILL/5 
--pidfile /run/onionbalance.pid
TimeoutStopSec=5
KillMode=mixed

EnvironmentFile=-/etc/default/%p
User=onionbalance
PermissionsStartOnly=true
Restart=on-abnormal
RestartSec=2s
LimitNOFILE=65536

# Hardening
# AppArmorProfile=system_onionbalance
# CapabilityBoundingSet=CAP_NET_BIND_SERVICE CAP_CHOWN CAP_FOWNER
NoNewPrivileges=yes
PrivateDevices=yes
PrivateTmp=yes
ProtectHome=yes
ProtectSystem=full
ReadOnlyDirectories=/
ReadWriteDirectories=-/proc
# ReadWriteDirectories=-/var/lib/onionbalance
ReadWriteDirectories=-/var/log/onionbalance
ReadWriteDirectories=-/var/run

[Install]
WantedBy=multi-user.target

= = =

$ lsb_release -rd
Description:    Ubuntu 16.04.2 LTS
Release:        16.04

= = =

$ apt-cache policy onionbalance
onionbalance:
  Installed: 0.1.3-3
  Candidate: 0.1.3-3
  Version table:
     0.1.3-3 500
        500 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages

** Affects: onionbalance (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1672901

Title:
  onionbalance.service fails to add dependencies

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/onionbalance/+bug/1672901/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to