Thank you for your contribution.

I am uploading this fix to Ubuntu 16.10 now. It will need to be manually
approved by the Ubuntu SRU Team before the update is available for
testing.

** Description changed:

  Impact
  ------
  The Chess app in Ubuntu 16.10 will crash when trying to promote a pawn.
  
  gnome-chess is not installed by default by any current Ubuntu flavors.
  
  Test Case
  ---------
  1. Open the Chess app and click Preferences in the app menu. Change Opposing 
Player to Human. Close Preferences.
  2. Make a move then click New Game to start a new game without a computer 
player.
  3. Move a pawn to the far end of the board to promote it to Queen.
  
  Does Chess crash after promoting?
  
  Regression Potential
  --------------------
  Low. This patch only affects pawn promotion which currently causes the game 
to crash so this is definitely an improvement.
  
  Other Info
  ----------
- I discussed this patch with Michael Catanzaro, the gnome-chess maintainer who 
had this to say:
- "That patch is one way to work around it... the workaround I used in Fedora 
is to not use any hardening flags when compiling the package. If anyone's 
computer gets hacked because someone finds a way to get code execution via 
malformed Portable Game Notation, then accept my apologies in advance. ;)"
+ There are 3 ways to fix this bug:
+ 1) Build gnome-chess without hardening flags. (This is the approach taken in 
Fedora 25).
+ 2) Apply a minimal workaround patch to gnome-chess. The patch was 
acknowledged by the gnome-chess maintainer, but he preferred to push for a 
proper fix in vala instead.
+ 3) Fix this in vala (it was fixed in vala 0.36 and 0.34.7) and then rebuild 
gnome-chess against the new vala.
+ 
+ I initially did #2 in Ubuntu 17.04 Beta (zesty) but will replace it with
+ #3.
+ 
+ I am using #2 for Ubuntu 16.10 since it seems a more minimal SRU.
  
  This only affect Ubuntu 16.10 since that was the first release where we
  opted gnome-chess into all available hardening flags.

** Changed in: gnome-chess (Ubuntu Yakkety)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1659828

Title:
  gnome-chess crash on pawn promotion

To manage notifications about this bug go to:
https://bugs.launchpad.net/vala/+bug/1659828/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to