Hi Mauricio,
thank you for the report!
I checked on a system with 2LUNs and 4 paths each.
Mine seemed to work just fine at first so I tried to get closer to your case.
It did so after reboot and in general, but maybe my setup needs tweaking to
trigger.
Yet unable to reproduce I focused on the code.
For now I'd want to:
1. get your help to recreate the issue - what more than having multipath
devices and rebooting do I need? Any special setup to force it to be more
active in the initramfs?
2. understand if we need to clear up more on /var/run vs /run? (see below)
3. why do I actually have both pid files populated - is that the same in your
case?
4. a few mods to your patch (see below)
----- 2 -------
I can at least confirm confusion on the .pid file, but don't know yet if that
might have been intentional:
sudo multipathd -k'show daemon'
pid 46392 idle
$ ll /var/run/multipathd.pid /run/multipathd.pid
-rw-r--r-- 1 root root 5 Mär 18 04:16 /run/multipathd.pid
-rw-r--r-- 1 root root 5 Mär 18 04:16 /var/run/multipathd.pid
$ cat /var/run/multipathd.pid
46392
$ cat /run/multipathd.pid
46392
So in a running system (not initrd) I have both pid files and they both
point to the right pid at least for me.
The define of the run dir gets to be only /run and then is in build log as
-DRUN_DIR=\"run\".
That just did not exist in Xenial/Yakkety at all, that is why we changed now.
Would we want/need to just get this to be /var/run/.. again?
If not there are way more references that need to be fixed up.
=> debian/multipath-tools.init isn't really used anyway other than for Debian
backports.
But while local-bottom is Ubuntu only, at least for this we might bother Debian
to know about.
Also there is this in Ubuntu's hooks:
63 # multipathd requires /var/run/multipathd.pid
64 mkdir -p $DESTDIR/var/run
Does it need it then it should now be /run right?
------4------
In the patch I think it overall makes sense to harden/improve the shutdown -
even not being able to reproduce yet, here some patch feedback:
+pid="$(pidof multipathd)"
I think this should get some safety if this does not return a pid.
There might be reasons to do so, and these should skip the whole shutdown part.
Also there might be some theoretical cases where the
+out="$(/sbin/multipathd -k'shutdown')"
As a side effect could make the pid change, so please re-arrange the pidof and
the shutdown.
BTW - Is the shutdown synchronous?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1670811
Title:
Multipath services fails to start on Ubuntu 17.04 on boot and kdump
(initramfs)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1670811/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
