I generally don't like SRUs that have one SRU bug for many fixes. Usually this rises a red flag.
That being said, this time I'll review it as is since actually each fix has a test case written here. The regression potential section could use some additional love though. Remember that the whole sense of that section is to give us an idea what could, completely theoretically, get broken by touching the selected pieces of code. So, even though something can have 'no regression potential', try thinking about what could have been broken accidentally by this change in the worst case scenario. That would make the review much easier. But before approving the upload (in case all goes well during the review) I'll re-upload it with a modified changelog entry as there is an LP bug mentioned that's invalidly taken into the SRU consideration. So there will be a reject followed by a new approval. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1685447 Title: SRU: resolve GTK+3.22 regressions in budgie-desktop To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/budgie-desktop/+bug/1685447/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
