** Description changed: - ---Problem Description--- + [Impact] ibmvscsis: Do not send aborted task response The driver is sending a response to the actual scsi op that was aborted by an abort task TM, while LIO is sending a response to the abort task TM. ibmvscsis_tgt does not send the response to the client until release_cmd time. The reason for this was because if we did it at queue_status time, then the client would be free to reuse the tag for that command, but we're still using the tag until the command is released at release_cmd time, so we chose to delay sending the response until then. That then caused this issue, because release_cmd is always called, even if queue_status is not. SCSI spec says that the initiator that sends the abort task TM NEVER gets a response to the aborted op and with the current code it will send a response. Thus this fix will remove that response if the CMD_T_ABORTED && !CMD_T_TAS. Another case with a small timing window is the case where if LIO sends a TMR_DOES_NOT_EXIST, and the release_cmd callback is called for the TMR Abort cmd before the release_cmd for the (attemped) aborted cmd, then we need to ensure that we send the response for the (attempted) abort cmd to the client before we send the response for the TMR Abort cmd. - [PATCH v3] ibmvscsis: Do not send aborted task response - https://www.spinics.net/lists/stable/msg170418.html + [Test Case] - This patch also requires a patch that was accepted upstream which is: + [Fix] + ibmvscsis: Fix the incorrect req_lim_delta + ibmvscsis: Clear left-over abort_cmd pointers + ibmvscsis: Do not send aborted task response target: Fix unknown fabric callback queue-full errors - https://patchwork.kernel.org/patch/9405013/ - - ---uname output--- - Latest Yakkety master branch - - Machine Type = P8 - - ---Steps to Reproduce--- - Send abort ops over and over and you will hit it. + + + [Regression Potential]
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1689365 Title: ibmvscsis: Do not send aborted task response To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1689365/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
