Initially looks good except a few things
1. Can you update the version number to a -0ubuntu1 style for
consistency
2. check-all-the-things stuff
$ check-all-the-things
$ find . -type f \( -iname '*.metainfo.xml' -o -iname '*.appdata.xml' \) -exec
appstreamcli validate --pedantic {} +
Validation was successful.
# Check with upstream where the Inkscape SVG source files are.
$ find . -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o
-iname '*.jpeg' \) -exec grep -nHiF inkscape {} +
Binary file ./data/banner.png matches
Binary file ./data/babe_128.png matches
Binary file ./data/playBtn.svg.png matches
Binary file ./BabeExtension/icon_1.png matches
Binary file ./BabeExtension/icon_done.png matches
Binary file ./BabeExtension/icon_2.png matches
$ grep -nHEr '/(home|srv|opt)(\W|$)' .
./CMakeLists.txt.user:70: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-babe-Desktop-Default</value>
./CMakeLists.txt.user:114: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-babe-Desktop-Debug</value>
./CMakeLists.txt.user:158: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-babe-Desktop-Release</value>
./CMakeLists.txt.user:202: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-babe-Desktop-Release
with Debug Information</value>
./CMakeLists.txt.user:246: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-babe-Desktop-Minimum
Size Release</value>
./CMakeLists.txt.user:344: <value type="QString"
key="CMakeProjectManager.CMakeRunConfiguration.UserWorkingDirectory.default">/home/camilo/Desktop/build-babe-Desktop-Default</value>
./style_examples/style.qss:10:
background-image:url("/home/camilo/.config/babe/pattern.png") repeat;
./BabeExtension/icon_push.svg:21:
inkscape:export-filename="/home/camilo/Coding/qt5/Babe/chrome_extension/icon_1.png"
./Babe.pro.user.972235b:69: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-Babe-Desktop-Debug</value>
./Babe.pro.user.972235b:129: <value type="QString"
key="ProjectExplorer.BuildConfiguration.BuildDirectory">/home/camilo/Desktop/build-Babe-Desktop-Release</value>
...
$ find . -type f \( -iname '*.ttf' -o -iname '*.otf' -o -iname '*.sfd' -o
-iname '*.pfa' -o -iname '*.pfb' -o -iname '*.bdf' -o -iname '*.pk' -o -iname
'*.ttc' -o -iname '*.pcf' \) -exec check-font-embedding-restrictions {} +
Traceback (most recent call last):
File "/usr/bin/check-font-embedding-restrictions", line 3, in <module>
import fontforge
ImportError: No module named fontforge
# check if these can be switched to https://
$ grep -nHrF http: .
./debian/copyright:45: this program. If not, see <http://www.gnu.org/licenses/>.
./data/media-playback-start.svg:3: xmlns:dc="http://purl.org/dc/elements/1.1/";
./data/media-playback-start.svg:4: xmlns:cc="http://creativecommons.org/ns#";
./data/media-playback-start.svg:5:
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
./data/media-playback-start.svg:6: xmlns:svg="http://www.w3.org/2000/svg";
./data/media-playback-start.svg:7: xmlns="http://www.w3.org/2000/svg";
./data/media-playback-start.svg:8:
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
./data/media-playback-start.svg:9:
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
./data/media-playback-start.svg:22:
rdf:resource="http://purl.org/dc/dcmitype/StillImage"; />
./data/cover_hover.svg:3: xmlns:dc="http://purl.org/dc/elements/1.1/";
...
$ licensecheck --check=. --recursive --copyright .
./collectionDB.cpp: GPL (v3 or later)
[Copyright: 2017 Camilo Higuita]
./CMakeLists.txt.user: *No copyright* UNKNOWN
./settings.h: *No copyright* UNKNOWN
./pulpo.h: *No copyright* UNKNOWN
./org.kde.babe.appdata.xml: *No copyright* UNKNOWN
...
$ env PERL5OPT=-m-lib=. lintian --info --display-info --display-experimental
--pedantic --show-overrides --color auto
Cannot find changes file for babe/0.0.0.1+p17.10+git20170615.0110-0, tried:
babe_0.0.0.1+p17.10+git20170615.0110-0_amd64.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_i386.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_multi.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_all.changes
babe_0.0.0.1+p17.10+git20170615.0110-0_source.changes
in the following dirs:
..
../build-area
/var/cache/pbuilder/result
$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn -o
-iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs -o
-iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o
-iname CMakeFiles -o -iname _build -o -iname _sgbak -o -iname autom4te.cache -o
-iname blib -o -iname cover_db -o -iname node_modules -o -iname '~.dep' -o
-iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' \) -prune -o -type f ! \(
-iname '*.bak' -o -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname
'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg'
-o -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname
'*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' -o
-iname '*.wav' \) -exec env PERL5OPT=-m-lib=. spellintian --picky {} +
./org.kde.babe.appdata.xml: let's you -> lets you
./org.kde.babe.appdata.xml: kde -> KDE
./settings.cpp: writting -> writing
./mainwindow.cpp.autosave: separte -> separate
./mpris2.cpp: dont -> don't
./README.md: let's you -> lets you
./README.md: kde -> KDE
./pulpo.cpp: doens't -> doesn't
./pulpo.cpp: api -> API
./cmake/modules/FindTaglib.cmake: endif endif (duplicate word) -> endif
...
$ suspicious-source
./BabeExtension.crx
./debian/babe.install
$ grep -nHriE 'fixme|todo|hack|xxx+|broken' .
./mainwindow.cpp.autosave:862:void MainWindow::keyPressEvent(QKeyEvent *event)
//todo
Binary file ./data/babe.png matches
Binary file ./data/ajax-loader.gif matches
Binary file ./data/playBtn.svg.png matches
Binary file ./screenshots/about_view.png matches
Binary file ./screenshots/albums_view.png matches
Binary file ./screenshots/collection_view.png matches
Binary file ./screenshots/artists_view.png matches
Binary file ./screenshots/chromium_extension.png matches
Binary file ./screenshots/settings_view.png matches
...
$ test -d ./debian &&
! grep -sq native debian/source/format &&
! test -e debian/upstream/metadata &&
echo 'Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata'
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
There are a few things regarding licensecheck and few typos that you might want
to look into
3. Lintian run:
$ lintian -I -E --pedantic babe_0.0.0.1+p17.10+git20170615.0110-0.dsc
E: babe source: debian-revision-should-not-be-zero
0.0.0.1+p17.10+git20170615.0110-0
I: babe source: vcs-field-uses-insecure-uri vcs-git
git://git.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/babe
I: babe source: wildcard-matches-nothing-in-dep5-copyright source/mpris2.h
(paragraph at line 5)
I: babe source: unused-file-paragraph-in-dep5-copyright paragraph at line 5
I: babe source: debian-watch-file-is-missing
Thanks!
** Changed in: ubuntu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1698009
Title:
[needs-packaging] Babe-Qt
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1698009/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
