Hi Dave, Thank you for going through this. I think it's OK if you want to keep the set of dat files available in sync with the set available in the development release. But then the changelog entry should make this clear.
I expected the changelog entry to match the diff that I was reviewing. When users view the entry, they would then expect the entry to match what they are about to receive (be it source or binaries). For backports it's often easier to base the changelog on one from the version that's being backported and add one further entry explaining the backport. In this case my previous paragraph would still be accurate: the user would see all the changes landing in the stable release, and reviewers would also see a diff that corresponded to them. However we have agreed that this update will be a cherry-pick, not a backport, so this wouldn't apply anyway. > ...I thought about not including the debian changelog entry in the x upload, but I like to error on the side of more information, and this vvvvvv part of the changelog entry matches identically to zesty and artful. I agree with the sentiment. More information is fine. However inaccurate or misleading information is not. So by all means use the information in the changelog entry from Artful as a starting point, but you do need to remove or correct parts that no longer apply. Given that we aren't backporting the packaging from Artful, I don't think it makes sense to include lines like "source: remove unneeded intel-ucode/ directory". As far as I can find, this isn't happening at all to users, neither in Xenial nor Zesty, and isn't represented in the diff. I can't find this directory in any sources anywhere (just looking at Ubuntu). > If you deem it crucially important... It's hardly crucially important, but I do think it's reasonable to expect that the changelog is accurate against what is actually going on, I think it's reasonable for users to expect this too, and I believe it's the SRU team's job to maintain this standard. Please correct as follows (or discuss further if you want to do something else): 1) Remove the comment about removing intel-ucode/, as I can't see that in the diff anywhere. 2) Fix or replace "remove superseded upstream data file" so what whatever you do say matches against what I see in each proposed diff (you can say something different for Xenial and Zesty if needed of course). If you're removing dats I think we do need to mention it. Saying something like "source: remove firmware dat files as needed to bring the shipped set in sync with those shipped in Artful" would be fine. 3) In general, make sure that the changelogs accurately describe the diffs that I will review. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1700373 Title: intel-microcode is out of date, version 20170707 fixes errata on 6th and 7th generation platforms To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/intel-microcode/+bug/1700373/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
