The upload looks fine and I'm *almost* good to accept it to xenial- proposed. I would like to have a bit more detail in the description: could you modify the test case so that one knows what would be the 'expected' result of the test?
A small thing also: for the regression potential, whenever I see just 'None' written I feel like questioning a little bit. The code does look in fact very safe though so it's not a blocking thing, but I was wondering if it's possible that something would be regressed by the 'Version' part being removed from list? Just thinking out loud. Anyway, I guess this would still be better than not working at all. That being said, the Regression Potential field is for guess work like this - thinking of possible scenarios that could cause issues after the update is released to the world. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1704817 Title: [Xenial] nvme-cli does not recognize version 1.0 NVME drives To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1704817/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
