On Wed, Sep 20, 2017 at 11:09:56AM -0000, bugproxy wrote: > (In reply to comment #5) > > For 17.10, I've attempted to upload the 1.1.18 upstream version rather than > > cherry-picking individual fixes. However, the package fails to build on the > > Ubuntu builders due to a series of bugs.
> > - when the test binary is built, it is linked against libservicelog.so, not > > libservicelog.la. This means that there is no libtool wrapper script to set > > the path; and the test binary only ever works if there is an > > already-installed version of libservicelog on the system path which is being > > tested instead of the just-built version. > > - if servicelog_open() returns a failure, test_libservicelog segfaults > > because it tries to dereference a null pointer. > > - if /var/lib/libservicelog/ does not already exist on the system, > > servicelog_open() will *always* fail. > > I've written patches for the first two issues; > Thanks for the patch. I didn't see your s-o-b in patch. Do you have any > objection in adding your s-o-b and merging these patches in upstream? The two patches are attached to the bug log in Launchpad: https://bugs.launchpad.net/ubuntu/+source/libservicelog/+bug/1705538/+attachment/4940508/+files/0001-Use-libtool-dependencies-for-linking-tests.patch https://bugs.launchpad.net/ubuntu/+source/libservicelog/+bug/1705538/+attachment/4940509/+files/0002-Fix-segfault-on-servicelog_open-failure.patch No objections to these being merged upstream. If you need something formal from Canonical regarding copyright / license, please let me know. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705538 Title: Update Package request for libservicelog To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1705538/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
