Public bug reported: vte-0.49 and tilix-1.5.8 introduce a brand new feature: custom hyperlinks (just like on webpages; the visible text is arbitrary, and the target URL is specified by an escape sequence).
This feature technically has nothing to with PCRE2. Since the target URL is explicitly specified and never guessed, no regex matching is involved at all. Your patch that removes PCRE2 support (or actually makes it conditional to a future vte version 0.60) also removes the custom hyperlink feature for no apparent reason. (And by the way it prints 0.50 in a debug message instead of 0.60, I guess that's a typo.) Please fix that patch to only bump the version requirement for PCRE2 and not for custom hyperlinks. I know at this moment Artful ships vte-0.48 so there's no immediate user visible problem here. However: - I'm not sure if it will upgrade to 0.50 before the final release, and then filing/fixing the Tilix issue might be too late; - People might compile a newer VTE manually or install from GNOME3 Staging once it appears there, and would expect this feature to work; - This problem will probably remain for 18.04 and you'd have to fix there anyways, so why not now. How to reproduce: After upgrading libvte-2.91-0 to 0.50, execute this command in Tilix: echo -e '\e]8;;https://www.ubuntu.com/\aCtrl+click here\e]8;;\a' Expected: "Ctrl+click here" appears with dotted underline, continuous underline on hover, and Ctrl+clicking opens Ubuntu's homepage in a browser. The right-click menu also contains corresponding "Open Link" and "Copy Link Address" entries. Actual: "Ctrl+click here" appears as simple text and nothing special happens upon hovering or Ctrl+clicking, and no related entries in the right-click menu. ProblemType: Bug DistroRelease: Ubuntu 17.10 Package: tilix (not installed) ProcVersionSignature: Ubuntu 4.13.0-11.12-generic 4.13.1 Uname: Linux 4.13.0-11-generic x86_64 ApportVersion: 2.20.7-0ubuntu1 Architecture: amd64 CurrentDesktop: Unity:Unity7:ubuntu Date: Fri Sep 22 12:23:55 2017 InstallationDate: Installed on 2016-11-09 (316 days ago) InstallationMedia: Ubuntu 16.10 "Yakkety Yak" - Release amd64 (20161012.2) SourcePackage: tilix UpgradeStatus: Upgraded to artful on 2017-09-21 (0 days ago) ** Affects: tilix (Ubuntu) Importance: Undecided Status: New ** Tags: amd64 apport-bug artful ** Description changed: vte-0.49 and tilix-1.5.8 introduce a brand new feature: custom hyperlinks (just like on webpages; the visible text is arbitrary, and the target URL is specified by an escape sequence). This feature technically has nothing to with PCRE2. Since the target URL is explicitly specified and never guessed, no regex matching is involved at all. Your patch that removes PCRE2 support (or actually makes it conditional to a future vte version 0.60) also removes the custom hyperlink feature for no apparent reason. (And by the way it prints 0.50 in a debug message instead of 0.60, I guess that's a typo.) Please fix that patch to only bump the version requirement for PCRE2 and not for custom hyperlinks. I know at this moment Artful ships vte-0.48 so there's no immediate user visible problem here. However: - I'm not sure if it will upgrade to 0.50 before the final release, and then filing/fixing the Tilix issue might be too late; - People might compile a newer VTE manually or install from GNOME3 Staging once it appears there, and would expect this feature to work; - This problem will probably remain for 18.04 and you'd have to fix there anyways, so why not now. How to reproduce: After upgrading libvte-2.91-0 to 0.50, execute this command in Tilix: echo -e '\e]8;;https://www.ubuntu.com/\aCtrl+click here\e]8;;\a' Expected: "Ctrl+click here" appears with dotted underline, continuous underline on hover, and Ctrl+clicking opens Ubuntu's homepage in a - browser. + browser. The right-click menu also contains corresponding "Open Link" + and "Copy Link Address" entries. Actual: "Ctrl+click here" appears as simple text and nothing special - happens upon hovering or Ctrl+clicking. + happens upon hovering or Ctrl+clicking, and no related entries in the + right-click menu. ProblemType: Bug DistroRelease: Ubuntu 17.10 Package: tilix (not installed) ProcVersionSignature: Ubuntu 4.13.0-11.12-generic 4.13.1 Uname: Linux 4.13.0-11-generic x86_64 ApportVersion: 2.20.7-0ubuntu1 Architecture: amd64 CurrentDesktop: Unity:Unity7:ubuntu Date: Fri Sep 22 12:23:55 2017 InstallationDate: Installed on 2016-11-09 (316 days ago) InstallationMedia: Ubuntu 16.10 "Yakkety Yak" - Release amd64 (20161012.2) SourcePackage: tilix UpgradeStatus: Upgraded to artful on 2017-09-21 (0 days ago) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1718909 Title: Hyperlink feature unexpectedly removed by PCRE2 patch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tilix/+bug/1718909/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
