Launchpad has imported 5 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=481146.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2009-01-22T12:58:44+00:00 John wrote:

Created attachment 329709
proposed fix

Description of problem:

When (without -pipe) the child exits, state->pipe is cleared but
state->pid is not. Later on, state->pid is used to determine whether to
send a message to the child (via state->pipe) it tests only the value of
state->pid.

This can be forced by running with -window and resizing the window
between child runs (which attempts to ioctl TIOCWINSZ on the pipe).

Version-Release number of selected component (if applicable):

xscreensaver-extras-5.08-1.fc9.x86_64

How reproducible:

The resize case, very. I think there's another semi-random crash case
too though.

Steps to Reproduce:
1. Run phosphor with -window
2. Resize window
3.
  
Actual results:

SEGV

Expected results:

No SEGV

Additional info:

Attached patch does two things: clear state->pid once we know the child
has exited, and check state->pipe before attempting to dereference it.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/comments/0

------------------------------------------------------------------------
On 2009-01-22T13:54:40+00:00 Mamoru wrote:

Well, I can reproduce what you see and your proposal patch
seems reasonable. I will release the modified xscreensaver,
thanks.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/comments/1

------------------------------------------------------------------------
On 2009-01-22T15:45:11+00:00 Mamoru wrote:

5.08-5.fc{11,10,9} is submitted:
For F-9:
http://koji.fedoraproject.org/koji/buildinfo?buildID=79778

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/comments/2

------------------------------------------------------------------------
On 2009-01-24T02:39:42+00:00 Fedora wrote:

xscreensaver-5.08-5.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this
bug report.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/comments/3

------------------------------------------------------------------------
On 2009-01-24T02:43:10+00:00 Fedora wrote:

xscreensaver-5.08-5.fc9 has been pushed to the Fedora 9 stable
repository.  If problems still persist, please make note of it in this
bug report.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/comments/4


** Changed in: xscreensaver (Fedora)
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/357556

Title:
  phosphor crashed with SIGSEGV in fileno_unlocked()

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/357556/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to