While looking for a way to test, I discovered that this needs additional changes. There will be a follow-up upload.
** Description changed: SRU Justification: Impact: When running cmd_up there are a few failure points which call fail_up to unwind but then do not exit with failure. This also has effect on running "fanatic enable-fan" which itself runs fanctl. Fix: Force the fail_up function to do a hard stop by adding an "exit 1" statement. - Testcase: TBD + Testcase: + [fan is installed but not enabled] + - sudo flock -x /run/xtables.lock sleep 300 + - fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1719644 Title: fanctl does not exit with an error when an up step fails To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1719644/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
