> I have reviewed this. +1 from ~ubuntu-sru. Thanks for the thoughtful review.
> What happens when the DHCP lease acquired in the initramfs expires? What > if the DNS server changes after a new lease? Really it's the entire DHCP > lease that needs handing over from the initramfs rather than just the > DNS server that was provided at the time of the first lease on boot. But > this will only affect this impacted non-default use case. If this > doesn't matter for you, then fine. If it does, then please mark > verification-failed and we can go again with a fix that will cover this > case. Agreed. This is not covered at this point, but never has been. In the open-iscsi path, we've been using this code for the maas use case since 12.04. Your point is valid, and we're hoping in 18.04 to correctly transition this lease over the "real root". The answer on "What happens" right now is "Nothing". The system will continue to use its initramfs-provided dhcp address. There is no persistent process that would re-evaluate the lease. > If not on systemd and inside a container, check will not work. We don't > support !systemd on Ubuntu, so that should be OK. We may be on upstart > after upgrading from Trusty; in that case the /proc/cmdline gate should > still work so this will only affect systems booted this way using MAAS > on Trusty and then upgraded to Xenial until next reboot. It doesn't specifically have to use systemd as init, just have the systemd-detect-virt. You're right, we could have done something else there, to cover a system that did not have that. > Adding a udev rule that is a shell script for every network up and down. > How does this effect udev, for example on a system with a large number > of flapping interfaces? On a quick glance I didn't see any other shell > script udev rule on such a wide reaching trigger. Open-iscsi *does* have such a rule (the implementation is borrowed from there). Also, open-iscsi is installed by default in all 16.04 images, so while not being as ubiquitious as resolvconf, it is very common. > Please make sure to test that the gating is working correctly in the > non-kernel-cmdline case during SRU verification. ACK. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1711760 Title: [2.3] resolv.conf is not set (during commissioning or testing) To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1711760/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
