** Description changed: - LP: #1060404 was addressed by making the update-grub kernel postinst - hook a no-op when running in containers. + [SRU Justification] + LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers. We now do all of our livefs builds in containers in Launchpad; this means livefses no longer get a grub config automatically generated with the correct contents when installing a kernel in the target, as they did previously. The change for LP: #1060404 was described by Colin as a "temporary fix". - We know that update-grub itself now succeeds in containers, because we - have several points in livefs builds where we are invoking it directly - and it does what we expect. + We know that update-grub itself now succeeds in the launchpad buildd + containers, because we have several points in livefs builds where we are + invoking it directly and it does what we expect. And in any containers + where update-grub does not work, these same livefs builds will fail + anyway. - We should check that running update-grub in a stock lxd container works - as expected, and that this isn't due to some sort of launchpad sauce. - Provided it does work, we should remove the container check from the - kernel postinst hook. + [Test case] + Run through a standard set of xenial image builds with livecd-rootfs in launchpad, including the private cloud image builds. Confirm that the builds are successful and that + + [Regression potential] + If something else relied on container detection in order to modify its behavior, and is called between the addition and removal of the systemd-detect-virt diversion, it could now behave incorrectly in a container and cause build failures. This is an entirely hypothetical scenario, since all current consumers of (un)divert_grub, and pending users of it, have it very narrowly scoped such that they're only doing update-grub / kernel install operations in between.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729034 Title: don't short-circuit update-grub kernel postinst hook in containers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1729034/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
