Looks like those two kfree's in dev_run can be dropped since that was an exit after kmalloc'ing env entries which are now only done in
bch_cached_dev_emit_change() which is only called by dev_run after it knows that the device is not yet running. On Mon, Dec 4, 2017 at 11:35 AM, Ryan Harper <[email protected]> wrote: > Hi Joseph, > > Sorry, I didn't give that a compile either; I just wanted to show what the > change could look like; > Let me see if I can get that to at least compile. > > > On Mon, Dec 4, 2017 at 11:18 AM, Joseph Salisbury < > [email protected]> wrote: > >> It looks like env[] was declared in bch_cached_dev_emit_change(), but >> not in bch_cached_dev_run(). >> >> -- >> You received this bug notification because you are subscribed to the bug >> report. >> https://bugs.launchpad.net/bugs/1729145 >> >> Title: >> /dev/bcache/by-uuid links not created after reboot >> >> To manage notifications about this bug go to: >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1729145 >> /+subscriptions >> > > -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729145 Title: /dev/bcache/by-uuid links not created after reboot To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1729145/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
