Hello Balint! I was looking at your package from the NEW POV (as part of training) and I have some questions/potential things that might be good to fix. This is not yet a formal review, I guess someone more experienced might follow up and do a full review.
First of all, the debian/copyright file needs to be updated as it's pointing to the vendor/github.com/docker/ directory which does not exist in the current repackaged tarball. Please change this accordingly. The README.source could be modified to make it clear why it made sense to repackage the tarball. Currently it only mentions the fact that we need to ship the containerd and docker newer versions - but that can't be the only reason as those are anyway shipped already by the upstream tarball in the vendor directory (so for this reason repackaging makes no sense). I guess you're repackaging the tarball to remove all the other unnecessary vendor-shipped packages, right? If that's the case, that needs to be stated in the README.source. >From smaller things I see that the debian/rules mentions xenial already, although we should basically care about bionic right now (those things can be introduced as a delta to xenial, or not mentioned at all). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1736397 Title: [needs-packaging] opengcs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1736397/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
