Analysis *before* situation: The loop after the __find call did not really match the __find call before - it was looking only for non- disabled sources, but then had an if case for disabled ones to enable them if the components match - which was never reached.
Now, I think the patch is slightly wrong: The if case is reachable now, so it would enable an existing disabled source even if we passed disabled=True. The for loop thus needs 4 cases now, the existing ones corresponding to disabled=False and two variants of them for disabled=True (might be possible to write with less cases). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
