It mostly looks good to me. The code is easy to maintain and it should
be straightforward.

Some things to fix:
* debian/copyright needs to be updated (some have 2017 copyright holders)

* Would be great to have those warnings fixed:
W: gnome-characters: appstream-metadata-in-legacy-location 
usr/share/appdata/org.gnome.Characters.appdata.xml

* Opened question: should we have a lintian override for:
W: gnome-characters: desktop-command-not-in-package 
usr/share/applications/org.gnome.Characters.desktop gapplication?
Also, related to this, as the .desktop is Exec=gapplication <…>, shouldn't the 
binary package dep on libglib2.0-bin?

** Changed in: gnome-characters (Ubuntu)
       Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1713176

Title:
  [MIR] gnome-characters

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-characters/+bug/1713176/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to