** Summary changed:

- TrackPoint: middle button doesn't work on TrackPoint-compatible device.
+ [SRU] TrackPoint: middle button doesn't work on TrackPoint-compatible device.

** Description changed:

  Lenovo introduced 4 new TrackPoint compatible sticks those only support
  the minimum commands described in the spec, which has been used in the
  current Windows driver.
  
  Legacy TrackPoint: 0101 – 0E01
  
  ALPS: 0102 – FF02
  
  ELAN:0103 – FF03
  
  NXP: 0104 – FF04
  
  TrackPoint (ID: 01/02) report 0 button when reading the EXT_BUTTON
  command.
  
  Setting middle button enabled to make it work.
  
  Upstream patch:
  commit f5d07b9e98022d50720e38aa936fc11c67868ece
  Author: Aaron Ma <[email protected]>
  Date:   Fri Jan 19 09:43:39 2018 -0800
  
      Input: trackpoint - force 3 buttons if 0 button is reported
      
      Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands.
      They supposed to reply with 0x02, 0x03, or 0x04 in response to the
      "Read Extended ID" command, so we would know not to try certain extended
      commands. Unfortunately even some trackpoints reporting the original IBM
      version (0x01 firmware 0x0e) now respond with incorrect data to the "Get
      Extended Buttons" command:
      
       thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown
       thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE
      
       psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0
      
      Since there are no trackpoints without buttons, let's assume the 
trackpoint
      has 3 buttons when we get 0 response to the extended buttons query.
      
      Signed-off-by: Aaron Ma <[email protected]>
      Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196253
      Cc: [email protected]
      Signed-off-by: Dmitry Torokhov <[email protected]>
+ 
+ 
+ SRU justification:
+ ==============
+ [Impact]
+ Middle button on some TrackPoints with ThinkPad can't work on Ubuntu
+ 16.04. 
+ Lenovo introduced 4 new TrackPoint compatible sticks those only support
+ minimum commands, Sticks with ID 01/02 reported the external button 0,
+ TrackPoint always have 3 buttons.
+ 
+ [Fix]
+ Set 3 buttons when 0 button is reported via PS/2 commands.
+ 
+ [Test Case]
+ Tested on Finn and E470, middle button works with this patch.
+ 
+ [Regression Potential]
+ No regression is expected.
+ 
+ This patch had been send to stable kernel, so Bionic should have it
+ with stable updates.
+ 
+ Aaron Ma (1):
+   Input: trackpoint - force 3 buttons if 0 button is reported
+ 
+  drivers/input/mouse/trackpoint.c | 3 +++
+  1 file changed, 3 insertions(+)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1746002

Title:
  [SRU] TrackPoint: middle button doesn't work on TrackPoint-compatible
  device.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1746002/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to