Public bug reported:
The trusty git-review packages list command fails with newer versions of
gerrit:
$ git review --list
Traceback (most recent call last):
File "/usr/bin/git-review", line 1196, in <module>
main()
File "/usr/bin/git-review", line 1129, in main
list_reviews(remote)
File "/usr/bin/git-review", line 697, in list_reviews
len(review_info[REVIEW_FIELDS[i]])
TypeError: object of type 'int' has no len()
The reason is a missing string conversion in the list_reviews function:
diff --git a/usr/bin/git-review b/git-review
index 1790ff7..0e0b0b7 100755
--- a/usr/bin/git-review
+++ b/git-review
@@ -694,7 +694,7 @@ def list_reviews(remote):
for i in FIELDS:
review_field_width[i] = max(
review_field_width[i],
- len(review_info[REVIEW_FIELDS[i]])
+ len(str(review_info[REVIEW_FIELDS[i]]))
)
review_field_format = " ".join([
$ lsb_release -rd
Description: Ubuntu 14.04.5 LTS
Release: 14.04
$ apt-cache policy git-review
git-review:
Installed: 1.23-1
Candidate: 1.23-1
Version table:
*** 1.23-1 0
500 http://some.local.mirror/ubuntu/ trusty/universe amd64 Packages
100 /var/lib/dpkg/status
** Affects: git-review (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1754289
Title:
git review list fails with newer gerrit versions
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git-review/+bug/1754289/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
