------- Comment From hegdevas...@in.ibm.com 2018-04-12 09:24 EDT------- Steve,
(In reply to comment #29) > > Also we have unit test cases in libservicelog package .. which is enough to > > cover basic > > validation. > > If I'm not mistaken, we still have this testsuite disabled in the package > because while I sent some fixes, servicelog_open() still fails if > /var/lib/servicelog does not exist. Does this mean you will plan to run > this testsuite manually against the packages in the SRU? Yes. Unfortunately we still need to disable test suites. Its in my TODO list .. but never got their due to various reasons. So we have 2 issues that blocks us enabling test suite by default. 1 - if servicelog_open() returns a failure, test_libservicelog segfaults because it tries to dereference a null pointer. I've applied your patch. I think we still left with one more place. I have patch locally to fix this issue. 2 - if /var/lib/libservicelog/ does not already exist on the system, servicelog_open() will *always* fail. I'm thinking of creating database under current dir itself and make it work. I will get this done in a day or two. -Vasant ------- Comment From hegdevas...@in.ibm.com 2018-04-12 09:28 EDT------- > > Update Package request for libservicelog. Some upstream patches have been > > requested to be included in both bionic and xenial. > > This is not a user impact explanation as described at > https://wiki.ubuntu.com/StableReleaseUpdates#Procedure and I can't find any > other justification or need for this to go to Xenial. > > Please could someone update the reason this need to go into Xenial from a > user perspective and update the bug description accordingly? Patches mentioned in this bugzilla can potentially impact customer environment. Hence we wanted those fixes in 16.04 LTS release. But when we added test cases we did broke it in build environment. Anyway this was new stuff added later. Let me know whether you can do some manually test and push changes? -OR- give test build so that IBM can test it before you merge? and I promise to test it ASAP . -Vasant -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705538 Title: Update Package request for libservicelog To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1705538/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
