Thanks for the patch!
On Thu, Apr 12, 2018 at 05:57:01PM -0000, Gunnar Hjalmarsson wrote:
> @Laney: I kept using %domains instead of @domains. ;) Given these
> adjustments I think that a hash is more suitable.
Not reviewing yet, but why? If the question is just asking one time
whether a string is in an array, you can use `if (grep { $_ eq string }
@array)' and I think it's clerarer than all of this. And similar for
removing the help domain except using `ne' and assigning the result back
to @domains. My main concern here is keeping the code readable. I don't
think we have to optimise away legibility for 1 or 2 lookups in a tiny
array.
OK, a slight review, it's confusing that --domain only works for meson;
is there any reason not to make that option cover other build systems
too?
Cheers,
--
Iain Lane [ i...@orangesquash.org.uk ]
Debian Developer [ la...@debian.org ]
Ubuntu Developer [ la...@ubuntu.com ]
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762889
Title:
dh_translations doesn't strip .desktop files when more than 1 pot
target with meson
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
