Looks good. I did a full code review, and while there is DBus use, and
this is a daemon that runs as root, the DBus code is minimal and only
serves to trigger running non-DBus code when a particular signal is
received. Similarly, the sd_notify (socket code) implementation is
limited to telling systemd that the daemon is ready. Values received
from DBus or by parsing commands are never directly used to call
programs: if there are any issues with, for example, SSIDs containing
characters that would break a script; any other python program is
equally affected when using env (ie. this would be a code Python issue).
MIR approved.
** Changed in: networkd-dispatcher (Ubuntu)
Status: New => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1764362
Title:
[MIR] networkd-dispatcher
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/networkd-dispatcher/+bug/1764362/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
