As described in testcases I set up a few guests and made sure some of them won't shutdown properly. We want to see 1. all tried to shut down 2. waiting up until timeout for the one that does not shut down
## Pre-Fix ## Xenial: sudo /usr/lib/libvirt/libvirt-guests.sh stop Running guests on default URI: b4, b1, b2, b3 Shutting down guests on default URI... Starting shutdown on guest: b4 Starting shutdown on guest: b1 Waiting for 4 guests to shut down, 120 seconds left Failed to determine state of guest: 83964d03-0d3b-47c3-a17d-fd104e2511f8. Not tracking it anymore. Failed to determine state of guest: 9f11ae0c-b73b-4d4b-abdb-b9acda341e84. Not tracking it anymore. Shutdown of guest b4 complete. Shutdown of guest b1 complete. Starting shutdown on guest: b2 Starting shutdown on guest: b3 Shutdown of guest b2 complete. Shutdown of guest b3 complete. root@x:~# virsh list Id Name State ---------------------------------------------------- 5 b4 running 6 b1 running 7 b2 running 8 b3 running Artful: # sudo /usr/lib/libvirt/libvirt-guests.sh stop Running guests on default URI: b1, b2, b3, b4 Shutting down guests on default URI... Starting shutdown on guest: b1 Starting shutdown on guest: b2 Waiting for 4 guests to shut down, 120 seconds left Failed to determine state of guest: 80ba5ac4-fb68-4ee7-b8d6-313313f29ab4. Not tracking it anymore. Failed to determine state of guest: 688847ca-5510-462d-ae5e-988d322d1471. Not tracking it anymore. Shutdown of guest b1 complete. Shutdown of guest b2 complete. Starting shutdown on guest: b3 Starting shutdown on guest: b4 Shutdown of guest b3 complete. Shutdown of guest b4 complete. root@a:~# virsh list Id Name State ---------------------------------------------------- 1 b1 running 4 b4 running #### With the fixes from proposed #### libvirt-bin/artful-proposed 3.6.0-1ubuntu6.6 amd64 [upgradable from: 3.6.0-1ubuntu6.5] libvirt-clients/artful-proposed 3.6.0-1ubuntu6.6 amd64 [upgradable from: 3.6.0-1ubuntu6.5] libvirt-daemon/artful-proposed 3.6.0-1ubuntu6.6 amd64 [upgradable from: 3.6.0-1ubuntu6.5] libvirt-daemon-system/artful-proposed 3.6.0-1ubuntu6.6 amd64 [upgradable from: 3.6.0-1ubuntu6.5] libvirt0/artful-proposed 3.6.0-1ubuntu6.6 amd64 [upgradable from: 3.6.0-1ubuntu6.5] libvirt-bin/xenial-proposed 1.3.1-1ubuntu10.22 amd64 [upgradable from: 1.3.1-1ubuntu10.21] libvirt0/xenial-proposed 1.3.1-1ubuntu10.22 amd64 [upgradable from: 1.3.1-1ubuntu10.21] Xenial: root@x:~# sudo /usr/lib/libvirt/libvirt-guests.sh stop Running guests on default URI: b4, b2, b1, b3 Shutting down guests on default URI... Starting shutdown on guest: b4 Starting shutdown on guest: b2 Waiting for 4 guests to shut down, 120 seconds left Waiting for 4 guests to shut down, 115 seconds left Waiting for 4 guests to shut down, 110 seconds left Waiting for 4 guests to shut down, 105 seconds left Waiting for 4 guests to shut down, 100 seconds left Waiting for 4 guests to shut down, 95 seconds left Waiting for 4 guests to shut down, 90 seconds left Waiting for 4 guests to shut down, 85 seconds left Waiting for 4 guests to shut down, 80 seconds left Shutdown of guest b2 complete. Starting shutdown on guest: b1 Waiting for 3 guests to shut down, 75 seconds left Waiting for 3 guests to shut down, 70 seconds left Waiting for 3 guests to shut down, 65 seconds left Shutdown of guest b1 complete. Starting shutdown on guest: b3 Waiting for 2 guests to shut down, 60 seconds left Waiting for 2 guests to shut down, 55 seconds left Waiting for 2 guests to shut down, 50 seconds left Waiting for 2 guests to shut down, 45 seconds left Waiting for 2 guests to shut down, 40 seconds left Shutdown of guest b3 complete. Waiting for 1 guests to shut down, 35 seconds left Waiting for 1 guests to shut down, 30 seconds left Waiting for 1 guests to shut down, 25 seconds left Waiting for 1 guests to shut down, 20 seconds left Waiting for 1 guests to shut down, 15 seconds left Waiting for 1 guests to shut down, 10 seconds left Waiting for 1 guests to shut down, 5 seconds left Timeout expired while shutting down domains root@x:~# virsh list Id Name State ---------------------------------------------------- 5 b4 running Artful: sudo /usr/lib/libvirt/libvirt-guests.sh stop Running guests on default URI: b4, b2, b3, b1 Shutting down guests on default URI... Starting shutdown on guest: b4 Starting shutdown on guest: b2 Waiting for 4 guests to shut down, 120 seconds left Shutdown of guest b2 complete. Starting shutdown on guest: b3 Shutdown of guest b3 complete. Starting shutdown on guest: b1 Waiting for 2 guests to shut down, 115 seconds left Shutdown of guest b1 complete. Waiting for 1 guests to shut down, 110 seconds left Waiting for 1 guests to shut down, 105 seconds left Waiting for 1 guests to shut down, 100 seconds left Waiting for 1 guests to shut down, 95 seconds left Waiting for 1 guests to shut down, 90 seconds left Waiting for 1 guests to shut down, 85 seconds left Waiting for 1 guests to shut down, 80 seconds left Waiting for 1 guests to shut down, 75 seconds left Waiting for 1 guests to shut down, 70 seconds left Waiting for 1 guests to shut down, 65 seconds left Waiting for 1 guests to shut down, 60 seconds left Waiting for 1 guests to shut down, 55 seconds left Waiting for 1 guests to shut down, 50 seconds left Waiting for 1 guests to shut down, 45 seconds left Waiting for 1 guests to shut down, 40 seconds left Waiting for 1 guests to shut down, 35 seconds left Waiting for 1 guests to shut down, 30 seconds left Waiting for 1 guests to shut down, 25 seconds left Waiting for 1 guests to shut down, 20 seconds left Waiting for 1 guests to shut down, 15 seconds left Waiting for 1 guests to shut down, 10 seconds left Waiting for 1 guests to shut down, 5 seconds left Timeout expired while shutting down domains That is just as we want/need it (b4 is the one I hacked to not shut down ever). Per the tests above settign verification done. ** Tags removed: verification-needed verification-needed-artful verification-needed-xenial ** Tags added: verification-done verification-done-artful verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1764668 Title: guest cleanup script fails to iterate To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
