Thanks Manoj. Some feedback...

This check is backwards:
ifeq (,$(filter $(DEB_HOST_ARCH),aarch64))

The way it is written, it is checking to see if $(DEB_HOST_ARCH) is
*not* in the string "aarch64". We want to this to be true if it is. It's
working for you because the $(DEB_HOST_ARCH) and $(DEB_TARGET_ARCH_CPU)
will be "arm64", not "aarch64", on an arm64 host so, in fact, arm64 !=
aarch64. However, neither is amd64, ppc64el, etc - end result is that
--enable-arm will be set on every architecture.

btw, the 'filter' function is for searching for a string in a list of words. 
aarch64 is just one word, so filter is overkill here. I think it'd be easier to 
understand to just say:
ifeq ($(DEB_HOST_ARCH),arm64)

Also, the ifeq section is currently between a comment and the code it
describes - mind moving that up? Thanks! Looking forward to the next
version..

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1769182

Title:
  ./configure --enable-arm needed for ARM events

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rasdaemon/+bug/1769182/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to