On Thu, May 10, 2018 at 3:03 PM, Bjorn Helgaas <[email protected]> wrote: > On Wed, May 09, 2018 at 12:18:32AM +0200, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki <[email protected]> >> >> Commit 0847684cfc5f0 (PCI / PM: Simplify device wakeup settings code) >> went too far and dropped the device_may_wakeup() check from >> pci_enable_wake() which causes wakeup to be enabled during system >> suspend, hibernation or shutdown for some PCI devices that are not >> allowed by user space to wake up the system from sleep (or power off). >> >> As a result of this excessive power is drawn by some of the affected >> systems while in sleep states or off. >> >> Restore the device_may_wakeup() check in pci_enable_wake(), but make >> sure that the PCI bus type's runtime suspend callback will not call >> device_may_wakeup() which is about system wakeup from sleep and not >> about device wakeup from runtime suspend. >> >> Fixes: 0847684cfc5f0 (PCI / PM: Simplify device wakeup settings code) >> Reported-by: Joseph Salisbury <[email protected]> >> Signed-off-by: Rafael J. Wysocki <[email protected]> > > Acked-by: Bjorn Helgaas <[email protected]> > > 0847684cfc5f0 appeared in v4.13, which raises the question of whether > this problem is important enough for a stable backport. Up to you :)
Yes, it is IMO, thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745646 Title: Battery drains when laptop is off (shutdown) To manage notifications about this bug go to: https://bugs.launchpad.net/linux/+bug/1745646/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
