** Patch added: "pkgbinarymangler_lp1762889_bionic.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+attachment/5143361/+files/pkgbinarymangler_lp1762889_bionic.debdiff

** Description changed:

+ [Impact]
+ 
+ With version 136 of the dh-translations package, support for the Meson
+ build system was added. While that change is sufficient for making
+ dh_translations run successfully for some Meson packages, it's not
+ sufficient for packages with multiple gettext domains, e.g.
+ help-[project] domains. As regards POT building, it has so far been
+ handled for several packages via overrides in debian/rules, but in most
+ cases the .desktop files in such packages are shipped with upstream
+ translations and without "X-Ubuntu-Gettext-Domain", so additional LP
+ translations are not made available to the users.
+ 
+ The proposed upload includes fixes from dh-translations 139 which deals
+ with it for the remaining Meson packages. This will improve it for a
+ number of packages to the extent they are SRUed to bionic.
+ 
+ [Test Case]
+ 
+ Let gnome-mines 1:3.28.0-1 be our use case. The file
+ 
+ /usr/share/applications/gnome-mines.desktop
+ 
+ includes upstream translations and no X-Ubuntu-Gettext-Domain.
+ 
+ Then:
+ 
+ * Install dh-translations 138.1 from bionic-proposed
+ * Build gnome-mines locally
+ 
+ and find that the .desktop file was stripped from upstream translations
+ and includes the line:
+ 
+ X-Ubuntu-Gettext-Domain=gnome-mines
+ 
+ [Regression Potential]
+ 
+ The backported changes address some build issues, and I find it hard to
+ see how they could cause new ones. In order to minimize the risk, one of
+ the changes in version 139, which is not considered 'safe safe', is not
+ included in this proposal.
+ 
+ Also, this package is not for users, so possible issues will at first
+ hand hit developers who can act on them in connection with uploads.
+ 
+ [Original description]
+ 
  The gnome.help() meson function creates a help-$project-pot target. This
  confuses dh_translations which complains:
  
  dh_translations: more than one meson translation domain found (help-
  gnome-calculator,gnome-calculator), don't know which one to use
  
  I think the only consequence of this is that the .desktop doesn't have
  its translations stripped and replaced with X-Ubuntu-Gettext-Domain=
  
  This means that Ubuntu translators are unable to update those
  translations.
  
  Affected Apps
  =============
  Therefore, this issue affects GNOME apps in main that use meson and also 
include help files.
  
  gnome-control-center is also affected because it happens to have an
  extra gettext domain (but does not ship help).
  
  libgweather gets the warning because it has a second gettext domain but
  it doesn't ship any .desktop files so I think the warning is harmless.
  
  Suggestion
  ==========
  Maybe dh_translations could just exclude targets that start with "help-". 
That would fix most of these cases.
  
  Other Info
  ==========
  This bug is split off LP: #1751820
  
  pkgbinarymanagler 136 in bionic
  
  References
  ==========
  http://mesonbuild.com/Gnome-module.html#gnomeyelp
  http://mesonbuild.com/Localisation.html

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1762889

Title:
  dh_translations doesn't strip .desktop files when more than 1 pot
  target with meson

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to