Thanks Andreas for helping me with this aspect of the current PG MRE! I reviewed both MPs and they LGTM and match my pre-tests I had yesterday.
I'm also adding a SRU Template Entry here. Furthermore I wanted to make clear that this is orthogonal to mark the old version of skytools as badtest for britney. I'd prefer to do both, mark it (the current version) bad AND SRU this change. ** Description changed: + [Impact] + + * A recent Security pushed CVE containing Postgres upload modified the + output of a few commands (good for safety, bad for tests checking exact + output). + + * We want to get the tests working and reliable again and for this + package that change seems rather easy to do, so lets do it. + + [Test Case] + + * Run the autopkgtests of skytools3 against current Xenial/Artful + + * You can just drop the file as the patch does and the tests will work + again. + + [Regression Potential] + + * This is a Test-Only change and currently Tests are totally broken on + all arches. So the only regression potential I see is a silly mistake + we might have missed in our Patch, but it is rather small and I doubt + there is one affecting the packages function. + + [Other Info] + + * Short Term the mark as badtest fixes this + * Mid Term we want the tests to work, therefore this non-functional test + only Upload (If we don't do that we end up with no tests after a + while). + + --- + Past security releases changed the output of postgres. Due to that autopkgtests are broken currently. Example: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest- artful/artful/amd64/s/skytools3/20180524_164925_7c562@/log.gz This should be safe to adapt and due to the CVE push not gating on it in the past is already a fact. So lets mask the current version a badtest and work on the fix if there is time. ** Description changed: [Impact] - * A recent Security pushed CVE containing Postgres upload modified the - output of a few commands (good for safety, bad for tests checking exact - output). + * A recent Security pushed CVE containing Postgres upload modified the + output of a few commands (good for safety, bad for tests checking exact + output). - * We want to get the tests working and reliable again and for this - package that change seems rather easy to do, so lets do it. + * We want to get the tests working and reliable again and for this + package that change seems rather easy to do, so lets do it. [Test Case] - * Run the autopkgtests of skytools3 against current Xenial/Artful + * Run the autopkgtests of skytools3 against current Xenial/Artful - * You can just drop the file as the patch does and the tests will work - again. + * You can just drop the file as the patch does and the tests will work + again. [Regression Potential] - * This is a Test-Only change and currently Tests are totally broken on - all arches. So the only regression potential I see is a silly mistake - we might have missed in our Patch, but it is rather small and I doubt - there is one affecting the packages function. + * This is a Test-Only change and currently Tests are totally broken on + all arches. So the only regression potential I see is a silly mistake + we might have missed in our Patch, but it is rather small and I doubt + there is one affecting the packages function. [Other Info] - - * Short Term the mark as badtest fixes this - * Mid Term we want the tests to work, therefore this non-functional test - only Upload (If we don't do that we end up with no tests after a - while). + + * Short Term the mark the current version as badtest (This also helps to + not let too much uploads depend to unblock on each other) + + * Mid Term we want the tests to work, therefore this non-functional test + only Upload proposed here (If we don't do that we end up with no tests + after a while). --- Past security releases changed the output of postgres. Due to that autopkgtests are broken currently. Example: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest- artful/artful/amd64/s/skytools3/20180524_164925_7c562@/log.gz This should be safe to adapt and due to the CVE push not gating on it in the past is already a fact. So lets mask the current version a badtest and work on the fix if there is time. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773763 Title: skytools3 autopkgtest broken in xenial and artful To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/skytools3/+bug/1773763/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
