Since this fix involves a lot of new logic being implemented, I would
like the validation to include *all* the aforementioned test cases:
regular desktop upgrade, server upgrade (making sure no snaps are
installed), desktop upgrade with no snap store connectivity (or
credentials?). I would also like to see a quick test for cases when,
let's say, one of these apps has both snap and deb versions on the
system before upgrade.

I'm also slightly concerned about the case handling in
_checkStoreConnectivity(). The res variable is not defined outside of
the conditionals, and I was wondering if there is a possibility of `snap
debug connectivity` returning an error that we did not expect
(especially since there is no else: case handled). In that case u-r-u
will just crash due to res being undefined.

Brian, I will be accepting it as is, but if that's indeed a valid
concern I'd prefer if this was fixed with an upload on top. If not,
we're good as is.

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1780841

Title:
  ubuntu-release-upgrader should transition debs to snaps

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1780841/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to