Attaching debdiff containing the fixes for the Bionic SRU. ** Description changed:
- == Comment: #0 - PAVITHRA R. PRAKASH <[email protected]> - 2018-03-01 00:30:14 == - ---Problem Description--- + [Impact] - Ubuntu 18.04 [ P9 WSP DD2.2 ]: lshw version is displayed as "unknown" - and -json option is not available in help message. + * lshw version is displayed as "unknown" + * '-json' option is not available in help message although it is a fully supported + + The version used to be set and then read from a text file named '.version' inside the upstream source, but since B.02.18 [1] the version is fetched from a shell call that relies on 'git describe'. This causes the version to set to "unknown" during the build. The proposed version fix has been uploaded upstream [2] and relies instead on reading from a 'VERSION' variable inside the makefile. The debdiff takes care of setting the variable to the right value in debian/rules. - ---Environment-- - Kernel Build: Ubuntu 18.04 - System Name : wcwsp3 - Model/Type : P9 - Platform : BML + The proposed fix also includes the '-json' to the help output and has + been uploaded upstream [3], as the json output has been supported and + recognized for a while. - ---Uname output--- - root@ltc-wcwsp3:~# uname -a - Linux ltc-wcwsp3 4.15.0-10-generic #11 SMP Thu Feb 22 23:50:53 EST 2018 ppc64le ppc64le ppc64le GNU/Linux + [Test Case] - ---Steps to reproduce-- + Trusty: + $ lshw -version + Hardware Lister (lshw) - B.02.16 - 1. Run below commands. + Bionic: + $ lshw -version + unknown - # lshw -version - # lshw -h - - ---Logs---- - - root@ltc-wcwsp3:~# lshw -version - unknown - root@ltc-wcwsp3:~# lshw -h + $ lshw -help Hardware Lister (lshw) - unknown usage: lshw [-format] [-options ...] lshw -version -version print program version (unknown) format can be -html output hardware tree as HTML -xml output hardware tree as XML -short output hardware paths -businfo output bus information options can be -class CLASS only show a certain class of hardware -C CLASS same as '-class CLASS' -c CLASS same as '-class CLASS' -disable TEST disable a test (like pci, isapnp, cpuid, etc. ) -enable TEST enable a test (like pci, isapnp, cpuid, etc. ) -quiet don't display status -sanitize sanitize output (remove sensitive information like serial numbers, etc.) -numeric output numeric IDs (for PCI, USB, etc.) -notime exclude volatile attributes (timestamps) from output + + Bionic patched: + $ lshw -version + B.02.18 + + $ lshw -help + Hardware Lister (lshw) - B.02.18 + usage: lshw [-format] [-options ...] + lshw -version + + -version print program version (B.02.18) + + format can be + -html output hardware tree as HTML + -xml output hardware tree as XML + -json output hardware tree as a JSON object + -short output hardware paths + -businfo output bus information + + options can be + -class CLASS only show a certain class of hardware + -C CLASS same as '-class CLASS' + -c CLASS same as '-class CLASS' + -disable TEST disable a test (like pci, isapnp, cpuid, etc. ) + -enable TEST enable a test (like pci, isapnp, cpuid, etc. ) + -quiet don't display status + -sanitize sanitize output (remove sensitive information like serial numbers, etc.) + -numeric output numeric IDs (for PCI, USB, etc.) + -notime exclude volatile attributes (timestamps) from output + + + [Regression Potential] + + * The version is set through the debian/rules variable VERSION, if set + incorrectly it will misreport the actual lshw version being used. + + [References] + + [1] https://github.com/lyonel/lshw/commit/2d0296cc31eefaba70f35c8b76af7dfc5f21b387 + [2] https://github.com/lyonel/lshw/commit/18edc98f9d08883f340087cfefbdf05c585d56f7 + [3] https://github.com/lyonel/lshw/commit/503c76a35a9e97a098af7c1ac793a7e13c07ce70 + + + [Original Bug Description] + == Comment: #0 - PAVITHRA R. PRAKASH <[email protected]> - 2018-03-01 00:30:14 == + ---Problem Description--- + + Ubuntu 18.04 [ P9 WSP DD2.2 ]: lshw version is displayed as "unknown" + and -json option is not available in help message. + + ---Environment-- + Kernel Build: Ubuntu 18.04 + System Name : wcwsp3 + Model/Type : P9 + Platform : BML + + ---Uname output--- + + root@ltc-wcwsp3:~# uname -a + Linux ltc-wcwsp3 4.15.0-10-generic #11 SMP Thu Feb 22 23:50:53 EST 2018 ppc64le ppc64le ppc64le GNU/Linux + + ---Steps to reproduce-- + + 1. Run below commands. + + # lshw -version + # lshw -h + + ---Logs---- + + root@ltc-wcwsp3:~# lshw -version + unknown + root@ltc-wcwsp3:~# lshw -h + Hardware Lister (lshw) - unknown + usage: lshw [-format] [-options ...] + lshw -version + + -version print program version (unknown) + + format can be + -html output hardware tree as HTML + -xml output hardware tree as XML + -short output hardware paths + -businfo output bus information + + options can be + -class CLASS only show a certain class of hardware + -C CLASS same as '-class CLASS' + -c CLASS same as '-class CLASS' + -disable TEST disable a test (like pci, isapnp, cpuid, etc. ) + -enable TEST enable a test (like pci, isapnp, cpuid, etc. ) + -quiet don't display status + -sanitize sanitize output (remove sensitive information like serial numbers, etc.) + -numeric output numeric IDs (for PCI, USB, etc.) + -notime exclude volatile attributes (timestamps) from output + == Comment: #1 - Chandni Verma <[email protected]> - 2018-03-01 02:48:01 == Upstream patches: https://github.com/lyonel/lshw/commit/18edc98f9d08883f340087cfefbdf05c585d56f7 and https://github.com/lyonel/lshw/commit/503c76a35a9e97a098af7c1ac793a7e13c07ce70 should fix the version and missing -json option issues respectively. Kindly cherry pick them and verify. Thanks! ** Patch added: "shw_02.18-0.1ubuntu6_debdiff_02.18-0.1ubuntu7.18.04.1.patch" https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1752523/+attachment/5162558/+files/shw_02.18-0.1ubuntu6_debdiff_02.18-0.1ubuntu7.18.04.1.patch ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752523 Title: Ubuntu 18.04 [ P9 WSP DD2.2 ]: lshw version is displayed as "unknown" and -json option is not available in help message. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/1752523/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
