** Description changed: Impact: The RaspberryPi 3 B Plus is the latest addition in the family of RaspberryPi boards, and this patchset includes all the necessary bits - (dts, lan driver and wifi fixes - backported from the official - https://github.com/raspberrypi/linux rpi-4.9.y tree) to enable this - board in our 4.4 Xenial raspi2 kernel. + (dts, lan driver and wifi fixes) to enable this board in our 4.4 Xenial + raspi2 kernel. How to test: - Build this kernel and try to boot a rpi3bplus with it: everything should - be working out of the box. + Build this kernel and boot a rpi3bplus with it: the board should boot + fine, ethernet lan and wifi should work too. Regression potential: - To ease the regression analysis, we can split the patchset in 3 - different set of patches: the dts files, the lan driver and the wifi - driver. + To ease the regression analysis, we can logically split the patchset in + 3 different set of patches: 1) the dts files (patches 0001 to 0006) Patch 0001 contains the pi3bplus board dts files + the lan dts fragment - these are new files, and don't modify any other dts in the tree. Patches 0002 to 0005 are the fixup modifcation to make the above dts file work in our 4.4 kernel. - Patch 006 is a fix for the bcm2708_common dts file - it's a small fix, and the same modification is present in the 4.9+ Raspberry respository too (see https://github.com/raspberrypi/linux/blob/rpi-4.9.y/arch/arm/boot/dts/bcm283x.dtsi aroud lines 353-354). + Patch 006 is a fix for the bcm2708_common dts file - it's a small fix, and the same modification is present in the 4.9+ Raspberry respository too (see https://github.com/raspberrypi/linux/blob/rpi-4.9.y/arch/arm/boot/dts/bcm283x.dtsi aroud lines 353-354) - unfortunately they squashed that fix, so i couldn't pick the specific commit. The only regression potential here is patch 0006, but since it's a small - fix, and it's even carried upstream in newer kernels, i mark it as low. + fix, and it's even carried upstream, i mark it as low. 2) the lan driver (patches 0008 to 0018) The rpi3bplus comes with a brand new gigabit capable ethernet adapter, driven by the lan 7515 chip, a chip mainly used in usb to ethernet adapter. Unfortunately, the lan7515 driver shipped in our Xenial tree - was not working: the driver would attaches, the interface shows up, - packets could be sent, but the host os never receives anything - + was not working: the driver would attach, the interface shows up, + packets could be sent, but the host os never received anything - sniffing the cable confirmed that traffic was generated, but we the NIC - was 'deaf'. After some debugging i found that no interrupt was generated - once any packet arrives and that was due to upstream + was 'deaf'. + + After some debugging i found that no interrupt was generated once packet + arrived and that was due to upstream 23374573a899528a4b10d76276646f69b7ae1572 "lan78xx: Correctly indicate invalid OTP", reverting this would bring my ethernet back to life (patch 0008. "lan78xx: Correctly indicate invalid OTP" originated around 4.17, way after a complete overhaul of the phy code wad done for all the usbnet driver - after more debugging i found that the 4.4 driver ships a - workaround to enable phy interrupts (see lan78xx_open()). + workaround to enable phy interrupts (see lan78xx_open()), so i'm + thinking there's some correlation between the phy overhaul and this + commit, for now i just reverted it locally and made the driver work + again. All the other patches (0009 to 0018) are backports of features added to the driver by the Raspberry Foundation, to make the driver better - integrates in a dts environment. + integrate in a dts environment. - There's no regression potential here, since the driver was not working - in the first place, and all the other Raspberry boards use a different - ethernet driver/chip. + There's literally no regression potential here, since the driver was not + working in the first place, and i actually had to fix it. - 3) the wifi driver (patches 0019 to 0024) + 3) the wifi driver (patches 0019 to 0026) The wifi chip used in the rpi3bplus is slightly different from the one - used in the original rpi3 board (), but uses the same driver: i - backported several fixes from the Raspberry tree to make it work... + used in the original rpi3 board, but uses the same driver: i backported + several fixes from upstream to make it work: all the commits fix an + isolated bugs, and can be easily reviewed. - There's some regression potential here, but all the code imported - actually fixes bugs so i say it's low. + There's some regression potential here, but all the code comes from + fixes upstream, so i make it as low.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1784025 Title: Support for the RaspberryPi 3 B Plus board To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-raspi2/+bug/1784025/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
