@mwhudson, your suggested change seems reasonable to me. I don't love the use of 'eval', but it seems reasonably safe here.
Instead of quoting you could just reject argv[1] input if it had characters other than [a-zA-z_.-] . Perhaps that makes this more difficult. Also, maybe you should try to 'setlocale(argv[1])' to check that it is valid ? Ie, as it is right now if input is bogus then the program will exit success and write bogus output. $ LC_ALL=asdf /tmp/my-test bogus ; echo $? LC_ALL='bogus' 0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1134036 Title: Failure when using ssh with a locale that is not configured on the server To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1134036/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
