Reviewing ubuntu-drivers-common in the queue, I notice:
+ if (!match) {
+ free(match);
Surely no good can come of this call to free() and it should be omitted?
The change to start before oem-config.service seems correct but has no
associated bug linked. This looks to me like it should still go through
the SRU verification process because it's unrelated to the other
changes. (Also, it's not 100% obvious that the change is correct: for
example, why does oem-config not provide display-manager.service? Why
are there no interdependencies between oem-config's systemd units and
display-manager.service?)
The source package as uploaded appears to have a lot of cruft in various
__pycache__ directories. This ought to be cleaned up.
I'm going to go ahead and reject based on the missing bug reference for
the oem-config.service change. If you think this is wrong, feel free to
ping me on IRC to discuss.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1778011
Title:
SRU: PRIME Power Saving mode draws too much power
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1778011/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
