I don't know if Matthias did a full NEW review of the package before
rejecting, so doing so now.

Five issues, one major, four minor:

- debian/copyright lists you as the copyright holder, Adam.  If this was
done for Canonical, which it's my understanding that it was, that is not
the correct copyright holder to list.  The copyright holder for
Canonical works should be "Canonical, Ltd".  Also, Canonical's policy is
to license works under GPLv3, not GPLv3+.  This needs to be resolved
before I will accept this package.

- debian/copyright has two different Files: stanzas, with the same
copyright and license information.  If the copyright and license is the
same, this is unnecessary duplication; there's no need to call out
debian/* in a separate stanza.

- lintian reports a quite old standards version in debian/control:
I: kubernetes source: out-of-date-standards-version 3.9.7 (released 2016-02-01) 
(current is 4.1.4)

- You are using debhelper compat level 9, but bionic ships with
debhelper 11.  If there's not a specific reason that you expect to build
this package on older Ubuntu releases (and note, I don't expect this to
be something that would make it through the SRU process), please use the
latest debhelper compat level at the time of the package's introduction.

- debian/dirs is not required; you only ever need to declare directories
in debian/dirs if you are shipping an empty dir in the binary package.

If debian/copyright is correct (which seems unlikely), let me know and I
can accept from the rejected queue.  Otherwise, please address the above
and reupload.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1780334

Title:
  kubernetes - new ubuntu package

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1780334/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to