Thanks for the patch. The approach broadly makes sense, three points for now:
* The documentation should be updated as well. * AFAICT _localize() is not handling the lang==NULL case correctly. * The calls to setlocale() are worrisome; we do use threads at least in the JavaScript runtime. It seems that gettext can work with per-thread locales (uselocale()), OTOH that might not be portable. (Honestly not sure about this. Colin?) (I haven’t reviewed the memory handling in detail -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/619632 Title: Use gettext for translating user messages To manage notifications about this bug go to: https://bugs.launchpad.net/policykit-1/+bug/619632/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
