Looks mostly good. The debian packaging is fine, use dh_missing --fail- missing to ensure we ship everything we want. It has autopkgtests doing unit testing under X. The only missing thing is the trailing commas on deps! :p
Some questions: * Any chance we can get a .symbol instead of a shlibs for better ABI and symbol tracking? * debian/30-tracker.conf: do we have an idea of the impact of the global system for this settings? * There is one lintian error (not overridden): E: tracker-extract: library-not-linked-against-libc usr/lib/x86_64-linux-gnu/tracker-miners-2.0/extract-modules/libextract-text.so (may be linked to the rpath issue mentioned above) * (Wish) The override doesn't have any comment on why rpath is acceptable for the binary. I didn't find anything in debian/changelog mentioning it as well. * (Wish) debian/tracker-miner-fs.preinst: would be good to use the internal maintainerscript tool to rm the conffiles, or just drop the whole conffiles removal as testing has 2.0.4-3, and it's not in stable, so nobody should get that case anymore. * (Opened question/Wish) I'm unsure why we have dbus and autostart activation. It doesn't seem to me that the service pauses after a while. Is there a way we can really only on one way of activating it, like dbus only? Notes: > Other optional binary universe dependencies are enabled in Debian but are > disabled in Ubuntu: > - enca > - libiptcdata > - libosinfo That looks indeed good, even if we are in sync with Debian. Note for security team: the conditional disabling is in debian/rules. I have seen some local caches being world readable, I think many years after after another security review would be great. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1770877 Title: [MIR] tracker-miners To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tracker-miners/+bug/1770877/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
