** Description changed:

- Hello.
+ [Impact]
+ Any Netplan user leaving empty files in /etc/netplan.
  
- We see on our jenkins some failing tests on machines updated with the
- bionic-proposed repository.
- 
- We found that netplan is crashing when there is an empty YAML
- configuration file.
- 
- To reproduce:
+ [Test case]
  
  1) put a valid configuration under /etc/netplan/
  2) create an empty YAML file /etc/netplan/99-empty.yaml
  3) execute netplan apply
+ 
+ Validate that 'netplan apply' does not crash, and correctly applies the
+ configuration.
+ 
+ 
+ [Regression potential]
+ Watch out for issues in merging netplan configuration or evaluating the parts 
of configuration that can't be reverted safely, for the use of 'netplan try'.
+ 
+ ---
  
  Traceback (most recent call last):
    File "/usr/sbin/netplan", line 23, in <module>
      netplan.main()
    File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/apply.py", line 43, in run
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/apply.py", line 83, in 
command_apply
      config_manager.parse()
    File "/usr/share/netplan/netplan/configmanager.py", line 111, in parse
      self._merge_yaml_config(yaml_file)
    File "/usr/share/netplan/netplan/configmanager.py", line 197, in 
_merge_yaml_config
      network = yaml_data.get('network')
  AttributeError: 'NoneType' object has no attribute 'get'
  Error in sys.excepthook:
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 145, in 
apport_excepthook
      os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as f:
  FileNotFoundError: [Errno 2] No such file or directory: 
'/var/crash/_usr_share_netplan_netplan.script.0.crash'
  
  Original exception was:
  Traceback (most recent call last):
    File "/usr/sbin/netplan", line 23, in <module>
      netplan.main()
    File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/apply.py", line 43, in run
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/apply.py", line 83, in 
command_apply
      config_manager.parse()
    File "/usr/share/netplan/netplan/configmanager.py", line 111, in parse
      self._merge_yaml_config(yaml_file)
    File "/usr/share/netplan/netplan/configmanager.py", line 197, in 
_merge_yaml_config
      network = yaml_data.get('network')
  AttributeError: 'NoneType' object has no attribute 'get'
  
  This is a regression with the previous version.
  
  apt policy netplan.io
  netplan.io:
    Installé : 0.40~18.04.1
    Candidat : 0.40~18.04.1
   Table de version :
   *** 0.40~18.04.1 500
          500 http://fr.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 
Packages
          100 /var/lib/dpkg/status
       0.36.3 500
          500 http://fr.archive.ubuntu.com/ubuntu bionic-updates/main amd64 
Packages
       0.36.1 500
          500 http://fr.archive.ubuntu.com/ubuntu bionic/main amd64 Packages
  
  Distributor ID:       Ubuntu
  Description:  Ubuntu 18.04.1 LTS
  Release:      18.04
  Codename:     bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1795343

Title:
  netplan backported on bionic (0.40~18.04.1) crash when there is an
  empty YAML configuration file

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1795343/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to