> * If called without arguments, the script throws a syntax error: This has also been fixed in later versions.
> This patch removes "WAS_ACTIVE" and uses ACTIVATE in one case The reason for the WAS_ACTIVE stuff is that the mount settings should be saved only if we are switching to laptop_mode (from not-active to active). Note that the script can be run several times, for instance when pulling the power cord and then closing the lid. If we saved the settings when AC was unplugged, we don't want to save them again (and overwrite the original settings with the new) when lid is closed. But ACTIVATE will be true in both cases. So I don't think your patch handles this correctly. OTOH it's not clear for me why the WAS_ACTIVE detection was ripped out either. -- laptop-mode remount does not work https://bugs.launchpad.net/bugs/113207 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
