Ok, I guessed wrong: more than one of the issues do require changes in
aboutDialog.js.
distroField.style.display = "block";
This fixes the second of the four issues I identified originally: it no
longer displays “Mozilla Firefox for Ubuntu” and “canonical - 1.0” as a
single line.
I would still change our “about=Mozilla Firefox for Ubuntu” to
“about=Customized for Ubuntu” or similar. Saying that it’s from Mozilla
is redundant with the sentence two lines below, and saying that it’s
Firefox is redundant with the main heading two lines above.
var distroId = Services.prefs.getCharPref("distribution.id", "");
if (distroId) {
var distroString = distroId;
var distroVersion = Services.prefs.getCharPref("distribution.version",
"");
if (distroVersion) {
distroString += " - " + distroVersion;
}
var distroIdField = document.getElementById("distributionId");
distroIdField.value = distroString;
So the first issue, “canonical” not being capitalized, could be fixed in three
ways:
A. changing our “id=canonical” to “id=Canonical” (though that might break
things elsewhere); or
B. changing our “app.distributor=canonical” to “app.distributor=Canonical”, and
changing the distroString code to use “app.distributor” rather than “id”; or
C. changing the format of the string in aboutDialog.js so that it isn’t
presenting id as a standalone word, for example “distroString = "(" +
distroString + "/" + distroVersion + ")”.
The third issue, the hyphen, could be fixed by C above, or by changing
it to a dash.
The fourth issue, the 1.0, could be fixed by C above, or by dropping the
“version=1.0” from our .ini file *and also* A or B above (so we don’t
end up with “canonical” on a line by itself).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/418203
Title:
"Mozilla Firefox for Ubuntu canonical - 1.0" doesn't make sense
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/418203/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
