* There are a lot of crash reports in launchpad. Those are several years old and shouldn't apply anymore. Maybe a little bit of cleanup of really old one, and looking at more recent ones will help once supported to review real new crashes (between launchpad and errors.ubuntu.com)? * What is going to pull rygel on the iso: directly seeded or a recommends/deps somewhere? Note that there is as well rygel-tracker which shouldn't be promoted until tracker situation is deciphered. * Some lintian warnings would be great to looked at, namely: - W: rygel-2.6-dev: pkg-config-unavailable-for-cross-compilation (multiple of thm) - W: rygel: uses-implicit-await-trigger interest /usr/lib/rygel-2.6 (line 1) - W: rygel: uses-implicit-await-trigger interest rygel-restart (line 2) * I guess rygel-preferences isn't going to be promoted, correct? (maybe we should list exactly the packages that are going to be promoted). It has a dep as linking on libgssdp-1.0-3, which is in universe. * However rygel binary package has some dep issues as well: - dep on libgssdp-1.0-3 (gssdp source in universe) and libgupnp-1.0-4 (gupnp source in universe), which are not listed in the current MIR for the stack. - 2 recommends with its source in universe and not listed to be MIRed. They should be downgraded to Suggests, if possible: gstreamer1.0-libav and gstreamer1.0-plugins-ugly * If we want to promote rygel-2.6-dev to main, there is again the libgupnp-1.0-dev dep as well which needs to be sorted out. * librygel-server-2.6-2 is a dep of rygel, and depends as well on libgssdp-1.0-3 and libgupnp-1.0-4 * librygel-renderer-2.6-2 is a dep of rygel, and depends as well on libgupnp-1.0-4 * librygel-core-2.6-2 is a dep of rygel, and depends as well on libgssdp-1.0-3 and libgupnp-1.0-4 * some copyright are missing: - 2008-2009 Florian Brosch - 2012 Choe Hwanjin <[email protected]> - 2013 Cable Television Laboratories, Inc. - 2014 Jens Georg <[email protected]> - 2014 Atlantic PuffinPack AB. - 2017 Samuel CUELLA] - Intel Corporation copyright should be extended to 2013 - Jens Georg copyright should be extended to 2016 I may have missed others but that should be about it.
Opened question: - tests are ran during package build, do we want autopkgtests (unsure if those are just unit tests or not, but it would maybe prevent at least vala regression)? - the doc is in the -dev package. That's ok with me, weird to have different standards considering debian maintainer is the same than the other packages though. I think there is a bunch of work to be done before going to another review or give a conditional +1 on that one. I'll defer also to the security team once the package is a little bit more ready from the pure MIR perspective. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786489 Title: [MIR] rygel To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rygel/+bug/1786489/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
