Launchpad has imported 7 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=3022.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2007-03-17T08:16:07+00:00 Yves-Alexis Perez wrote:

User-Agent:       Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8.0.10) 
Gecko/20070209 (Debian-1.8.0.10-3) Epiphany/2.14
Build Identifier: 

Hi,

I use xfce4-panel with a small size (24/25 mostly), and I think that
launchers icons are quite smaller than the panel size itself. Looking at
the code, it seems that a fixed margin is added around the icon, 2px
wide. I've tried removing this margin and I find the panel more good
looking without it.

It looks good at every size, but maybe at large size it would make more
sense to remove the variable size margin, I don't know.

Anyway, I've attached the patch, if you want to try it. I guess there
are design  issue I didn't see so maybe it's a very bad idea, but anyway
here is a wishlist bug to reduce margin size :)

Reproducible: Always

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/1

------------------------------------------------------------------------
On 2007-03-17T08:17:12+00:00 Yves-Alexis Perez wrote:

Created attachment 1036
disable fixed-width margin on launchers

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/2

------------------------------------------------------------------------
On 2007-03-17T08:36:45+00:00 Jasper Huijsmans wrote:

Hmm, those margins are there not because I like the extra empty space,
but rather to prevent cut-off icons.

The plugin size is not currently used as the icon size (there's a bug
open about this from Benedikt), so we need to take into account the
extra space used by the button. As far as I know a gtk button uses at
least a fixed border of 1 plus the theme-dependend x/ythickness.

If there is a plugin on your panel that is bigger than than the size you
set in the configuration it may happen that the launcher icons are
smaller than the available space.

I just tested by just removing the fixed border and I already see cut-
off icons, so I don't think I can commit this patch.


Reply at: 
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/3

------------------------------------------------------------------------
On 2007-03-17T08:51:28+00:00 Yves-Alexis Perez wrote:

(In reply to comment #2)
> Hmm, those margins are there not because I like the extra empty space, but
> rather to prevent cut-off icons. 

Yes, I wasn't implying this :)
> 
> The plugin size is not currently used as the icon size (there's a bug open
> about this from Benedikt), so we need to take into account the extra space 
> used
> by the button. As far as I know a gtk button uses at least a fixed border of 1
> plus the theme-dependend x/ythickness. 
> 
> If there is a plugin on your panel that is bigger than than the size you set 
> in
> the configuration it may happen that the launcher icons are smaller than the
> available space.
> 
> I just tested by just removing the fixed border and I already see cut-off
> icons, so I don't think I can commit this patch.

I see, and it was the "design issues" I feared. But in this case,
shouldn't the plugin be fixed to respect the panel size? When I set a
panel size I expect all plugins to respect it so I end with a panel
which size *is* the size I've chosen and not the size a plugin
requested. In case a plugin size and the panel size mismatchs, the
launcher icon may be really tiny (because it follow the panel requested
size, minus margin, while the panel at the end has the "bad" plugin
size.)

Regards,

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/4

------------------------------------------------------------------------
On 2008-10-24T05:15:44+00:00 8-nick wrote:

We can only improve this by using XfceScaledImage. I've fixed some
issues in this widget and it will be available in the 4.8 panel. Maybe
I'll add an icon-only mode to the launcher too (without gtkbutton),
since that might look better with a transparent panel, but I'm not sure
yet.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/7

------------------------------------------------------------------------
On 2010-02-02T18:01:24+00:00 8-nick wrote:

The XfcePanelImage widget should automatically set the biggest icon
possible (based on the widget allocation), so that part is fixed.

Changing the bug to allow a button-less launcher.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/8

------------------------------------------------------------------------
On 2018-12-05T23:46:07+00:00 Simon SteinbeiƟ wrote:

This is possible with Gtk+3 theming now.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/58553/comments/10


** Changed in: xfce4-panel
       Status: In Progress => Fix Released

** Changed in: xfce4-panel
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/58553

Title:
  [edgy] Many icons are presented with too much whitespace

To manage notifications about this bug go to:
https://bugs.launchpad.net/xfce4-panel/+bug/58553/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to