Public bug reported: [Impact]
The ubuntu-image classic build functionality offers the --with-proposed option for building images with -proposed enabled. Due to a bug in logic that was not noticed for a while, the --with-proposed option has no effect as -proposed is always enabled. This means that currently it is impossible to build images without proposed enabled in the rootfs. [Test Case] * git clone https://github.com/sil2100/pc-amd64-gadget.git * cd pc-amd64-gadget/ * snapcraft prime * Run build with proposed disabled: ubuntu-image classic -d -O out/ -w work/ -p ubuntu-cpc -a amd64 -s bionic prime/ * Check the build logs (also present in work/) and make sure bionic-proposed was not used * rm -rf out/ work/ * Run build with proposed enabled: ubuntu-image classic -d -O out/ -w work/ -p ubuntu-cpc -a amd64 -s bionic --with-proposed prime/ * Check the build logs (also present in work/) and make sure bionic-proposed was enabled and used [Regression Potential] The change is self-contained to the logic of with-proposed handling so the only possible regressions are in enabling/disabling proposed - which was currently broken anyway. ** Affects: ubuntu-image Importance: Critical Assignee: Łukasz Zemczak (sil2100) Status: Fix Committed ** Affects: ubuntu-image (Ubuntu) Importance: High Status: Fix Released ** Affects: ubuntu-image (Ubuntu Xenial) Importance: High Status: In Progress ** Affects: ubuntu-image (Ubuntu Bionic) Importance: Critical Status: In Progress ** Affects: ubuntu-image (Ubuntu Cosmic) Importance: High Status: In Progress ** Changed in: ubuntu-image Status: Fix Released => Fix Committed ** Also affects: ubuntu-image (Ubuntu) Importance: Undecided Status: New ** Changed in: ubuntu-image (Ubuntu) Status: New => Fix Released ** Also affects: ubuntu-image (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: ubuntu-image (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: ubuntu-image (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: ubuntu-image (Ubuntu Xenial) Status: New => Confirmed ** Changed in: ubuntu-image (Ubuntu Bionic) Status: New => Confirmed ** Changed in: ubuntu-image (Ubuntu Cosmic) Status: New => Confirmed ** Changed in: ubuntu-image (Ubuntu Bionic) Importance: Undecided => Critical ** Changed in: ubuntu-image (Ubuntu Cosmic) Importance: Undecided => High ** Changed in: ubuntu-image (Ubuntu Xenial) Importance: Undecided => High ** Changed in: ubuntu-image (Ubuntu) Importance: Undecided => High ** Changed in: ubuntu-image (Ubuntu Xenial) Status: Confirmed => In Progress ** Changed in: ubuntu-image (Ubuntu Bionic) Status: Confirmed => In Progress ** Changed in: ubuntu-image (Ubuntu Cosmic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1808402 Title: --with-proposed always enabled for ubuntu-image classic build To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-image/+bug/1808402/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
