hi, here are some clarifications on this bug:

> https://salsa.debian.org/debian/vlan/blob/debian/debian/network/if-pre-up.d/vlan#L21
> https://salsa.debian.org/debian/vlan/commit/7517228145310a29b7cb7f4bddccb1b70df347eb

these have nothing to do with this bug.  those changes are in case
sections that don't match the naming of your interface - yours starts
with "br-*" while those changes are in sections that only match actual
interface naming (i.e., not starting with "br-").

Additionally, I'm pretty sure that check was incorrectly written and has
never worked the way they thought it was working - i.e. it should check
for -n "$IF_BRIDGE_PORTS", but it doesn't, it checks for -z, so it
*won't* exit when called for a device that includes a 'bridge_ports'
param - it will exit for a normally-named interface with vlan extension
*without* vlan-raw-device or bridge_ports defined, which may be why it
was removed from ubuntu long ago (looks like it was re-introduced to
ubuntu in cosmic, so i should probably go and fix that too).

>
https://git.launchpad.net/ubuntu/+source/vlan/commit/?id=4c88eab61549ec4c6c8ed65e9610fca712ed98f4

getting closer with this one, but not quite there yet :)

this is the change that introduces this regression:

https://git.launchpad.net/ubuntu/+source/vlan/commit/?h=applied/ubuntu
/bionic-devel&id=117d183fa16e2d5e43da4cfe03e7e8685d27c6d1

yep it was me, sorry.

I want to say that I absolutely *HATE* the debian ifupdown api that
allows this kind of 'automagic' vlan creation just by appending ".NNN"
to an interface's name.  Is it *really* so hard to add a simple "vlan-
raw-device" param to the config?  The 'automagic'-ness of it makes
things *much* harder - especially when there are special cases like
this, a bridge on top of a vlan.

In any case, we can fix this regression by special-casing any configured
interface that includes a "bridge_ports" param, which (basically) should
get us back to how things worked before.

However, I personally think it's super, super confusing for juju to name
a bridge device with vlan suffix, and I highly support the juju patch
from comment 3 that changes the '.' to '-' (in addition to fixing this
regression in vlan).


** Changed in: vlan (Ubuntu)
     Assignee: (unassigned) => Dan Streetman (ddstreet)

** Changed in: vlan (Ubuntu)
   Importance: Undecided => Medium

** Changed in: vlan (Ubuntu)
       Status: New => In Progress

** Also affects: vlan (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Also affects: vlan (Ubuntu Cosmic)
   Importance: Undecided
       Status: New

** Also affects: vlan (Ubuntu Trusty)
   Importance: Undecided
       Status: New

** Also affects: vlan (Ubuntu Disco)
   Importance: Medium
     Assignee: Dan Streetman (ddstreet)
       Status: In Progress

** Also affects: vlan (Ubuntu Bionic)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1804018

Title:
  Autogenerated interface name prevents creating a bridge over a VLAN

To manage notifications about this bug go to:
https://bugs.launchpad.net/juju/+bug/1804018/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to