** Description changed: + [Impact] + + * diag308 doesn't behave correctly (hw error instead of program + interrupt) + + * Solution; Backport upstream accepted fix + + [Test Case] + + * Download the test image in comment #3 + + * Run the test kernel in qemu (on s390x) like: + /usr/local/bin/qemu-system-s390x -nodefaults -nographic -machine s390-ccw-virtio,accel=kvm -chardev stdio,id=con0 -device sclpconsole,chardev=con0 -kernel s390x/diag308.elf + + * Should report a proper abort/exception like + ABORT: diag308: Unexpected program interrupt: 6 at 0x134be, ilen 4 + Without the fix it is a hard crash + + [Regression Potential] + + * In both cases the guest breaks, with the fix in place it breaks with a + better message and the guest kernel could actually handle the program + interrupt if it wanted. + Since the old case was a full crash of the qemu userspace and this si + the only code path modified I can't see potential regressions triggered + by this change. + + [Other Info] + + * n/a + + + --- + The presence of subcodes is indicated by checking some query subcode. For example 6 will indicate that 3-6 are available. So future systems might call new subcodes to check for new features. This should not trigger a hw error, instead we return the architectured specification exception. Commit has been accepted by maintainer: https://github.com/cohuck/qemu/commit/f0646afaccf6bc1b196fc068eef75938db303814 Commit ID will be provided once it's upstream:
** Description changed: [Impact] - * diag308 doesn't behave correctly (hw error instead of program - interrupt) + * diag308 doesn't behave correctly (hw error instead of program + interrupt) - * Solution; Backport upstream accepted fix + * Solution; Backport upstream accepted fix [Test Case] - * Download the test image in comment #3 + * Download the test image in comment #3 - * Run the test kernel in qemu (on s390x) like: - /usr/local/bin/qemu-system-s390x -nodefaults -nographic -machine s390-ccw-virtio,accel=kvm -chardev stdio,id=con0 -device sclpconsole,chardev=con0 -kernel s390x/diag308.elf + * Run the test kernel in qemu (on s390x) like: + /usr/local/bin/qemu-system-s390x -nodefaults -nographic -machine s390-ccw-virtio,accel=kvm -chardev stdio,id=con0 -device sclpconsole,chardev=con0 -kernel s390x/diag308.elf - * Should report a proper abort/exception like - ABORT: diag308: Unexpected program interrupt: 6 at 0x134be, ilen 4 - Without the fix it is a hard crash + * Should report a proper abort/exception like + ABORT: diag308: Unexpected program interrupt: 6 at 0x134be, ilen 4 + Without the fix it is a hard crash [Regression Potential] - * In both cases the guest breaks, with the fix in place it breaks with a - better message and the guest kernel could actually handle the program - interrupt if it wanted. - Since the old case was a full crash of the qemu userspace and this si - the only code path modified I can't see potential regressions triggered - by this change. + * In both cases the guest breaks, with the fix in place it breaks with a + better message and the guest kernel could actually handle the program + interrupt if it wanted. + Since the old case was a full crash of the qemu userspace and this si + the only code path modified I can't see potential regressions triggered + by this change. [Other Info] - - * n/a + + * I doubt we call a special test kernel a "real case" for the SRU, but + future guests (e.g. Ubuntu 20.04) might trigger subcodes not yet + known to older qmeu (e.g. in 18.04) so adding this is a good safety + net for any such upcoming changes. --- The presence of subcodes is indicated by checking some query subcode. For example 6 will indicate that 3-6 are available. So future systems might call new subcodes to check for new features. This should not trigger a hw error, instead we return the architectured specification exception. Commit has been accepted by maintainer: https://github.com/cohuck/qemu/commit/f0646afaccf6bc1b196fc068eef75938db303814 Commit ID will be provided once it's upstream: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1812384 Title: [Ubuntu] qemu - backport diag308 stable exception fix To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1812384/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
