python-certbot backport review: The changes you've described look good in general, but I have some specific questions for pieces for which I couldn't find any explanation:
python-certbot no longer Recommends certbot, but python3-certbot did. Is this intentional? In debian/rules, what's the reason for including pkg-info.mk into the backport as a delta? I don't see the variables it defines being used anywhere. What's the reason for the new clean target in debian/rules? Why is certbot.timer's installation being removed? Has auto renewal been tested? If so, what's the mechanism it uses now? Why remove the installation of the cli.ini that disables certbot- internal log rotation? Some notes to self explaining further bits of the delta I did manage to understand: python3-distutils build-dep drop not explained but distutils is integrated in Python 2 in Xenial and not in its own packaging so dropping the build dependency is presumably intentional. The dropping of the python3-repoze.sphinx.autointerface build dependency is explained later with the disable-autointerface-docs patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt from bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
