Code and packaging looks good. Nothing to worry about. Are we promoting
all binaries, or only the lib? (and let the -dev, gir and tools in
universe).

One thing to fix though (I'm happy to not block and require a new upload if 
this is comitted in salsa):
* debian/copyright isn't up to date and correct:
-> Tristan copyright is 2013-2014 and not only 2013.
-> gsound/gsound-attr.h should mention as well 2008 Lennart Poettering

Suggestion for future uploads:
* It would be great to use dh_missing to ensure we don't miss any file.

And that's it for me. ack on the first condition is met!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1815095

Title:
  [MIR] gsound

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gsound/+bug/1815095/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to